Re: [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

On Mon, Feb 01, 2016 at 01:41:45PM -0600, Li Yang wrote: > On Mon, Feb 1, 2016 at 4:46 AM, Raghav Dogra wrote: > > A general comment is that you should include the linux-mtd mailing > list and it's maintainers for this set of patches. Although the > MAINTAINERS file

Re: [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

On Mon, Feb 1, 2016 at 4:46 AM, Raghav Dogra wrote: A general comment is that you should include the linux-mtd mailing list and it's maintainers for this set of patches. Although the MAINTAINERS file doesn't specify a maintainer for drivers/memory directory, it should be

Re: [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

On Mon, 2016-02-01 at 16:16 +0530, Raghav Dogra wrote: > /* > * IFC Controller Registers > */ > -struct fsl_ifc_regs { > +struct fsl_ifc_fcm { > __be32 ifc_rev; > u32 res1[0x2]; > struct { This struct is not specific to fcm (i.e. nand). Please choose a better name, such as

[PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

IFC has two set of registers viz FCM (Flash control machine) aka global and run time registers. These set are defined in two memory map PAGES. Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB Signed-off-by: Jaiprakash Singh Signed-off-by: Raghav Dogra