Re: [PATCH 3/6] powerpc/fsl_pci: Added defines for the FSL PCI controller BRR1 register.

2013-02-28 Thread Kumar Gala

On Feb 27, 2013, at 5:33 AM, Joerg Roedel wrote:

 On Mon, Feb 18, 2013 at 06:22:16PM +0530, Varun Sethi wrote:
 Macros for checking FSL PCI controller version.
 
 Signed-off-by: Varun Sethi varun.se...@freescale.com
 ---
 arch/powerpc/include/asm/pci-bridge.h |4 
 1 files changed, 4 insertions(+), 0 deletions(-)
 
 diff --git a/arch/powerpc/include/asm/pci-bridge.h 
 b/arch/powerpc/include/asm/pci-bridge.h
 index 025a130..c12ed78 100644
 --- a/arch/powerpc/include/asm/pci-bridge.h
 +++ b/arch/powerpc/include/asm/pci-bridge.h
 @@ -14,6 +14,10 @@
 
 struct device_node;
 
 +/* FSL PCI controller BRR1 register */
 +#define PCI_FSL_BRR1  0xbf8
 +#define PCI_FSL_BRR1_VER 0x
 +
 
 
 Please merge this patch with the one where you actually make use of
 these defines for the first time.
 
 
   Joerg

This also seems an odd place for these defines.

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: [PATCH 3/6] powerpc/fsl_pci: Added defines for the FSL PCI controller BRR1 register.

2013-02-27 Thread Joerg Roedel
On Mon, Feb 18, 2013 at 06:22:16PM +0530, Varun Sethi wrote:
 Macros for checking FSL PCI controller version.
 
 Signed-off-by: Varun Sethi varun.se...@freescale.com
 ---
  arch/powerpc/include/asm/pci-bridge.h |4 
  1 files changed, 4 insertions(+), 0 deletions(-)
 
 diff --git a/arch/powerpc/include/asm/pci-bridge.h 
 b/arch/powerpc/include/asm/pci-bridge.h
 index 025a130..c12ed78 100644
 --- a/arch/powerpc/include/asm/pci-bridge.h
 +++ b/arch/powerpc/include/asm/pci-bridge.h
 @@ -14,6 +14,10 @@
  
  struct device_node;
  
 +/* FSL PCI controller BRR1 register */
 +#define PCI_FSL_BRR1  0xbf8
 +#define PCI_FSL_BRR1_VER 0x
 +


Please merge this patch with the one where you actually make use of
these defines for the first time.


Joerg


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH 3/6] powerpc/fsl_pci: Added defines for the FSL PCI controller BRR1 register.

2013-02-18 Thread Varun Sethi
Macros for checking FSL PCI controller version.

Signed-off-by: Varun Sethi varun.se...@freescale.com
---
 arch/powerpc/include/asm/pci-bridge.h |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/include/asm/pci-bridge.h 
b/arch/powerpc/include/asm/pci-bridge.h
index 025a130..c12ed78 100644
--- a/arch/powerpc/include/asm/pci-bridge.h
+++ b/arch/powerpc/include/asm/pci-bridge.h
@@ -14,6 +14,10 @@
 
 struct device_node;
 
+/* FSL PCI controller BRR1 register */
+#define PCI_FSL_BRR1  0xbf8
+#define PCI_FSL_BRR1_VER 0x
+
 /*
  * Structure of a PCI controller (host bridge)
  */
-- 
1.7.4.1


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev