Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-13 Thread Gustavo A. R. Silva
On 10/13/18 3:23 AM, Kees Cook wrote: >> >> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback >> include/linux/compat.h >> linux-ker...@vger.kernel.org (open list) > > Normally things like that go through akpm, but I'm happy to carry them > if needed. > Oh okay. Let me try

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-12 Thread Kees Cook
On Fri, Oct 12, 2018 at 2:59 AM, Gustavo A. R. Silva wrote: > > > On 10/12/18 11:32 AM, Michael Ellerman wrote: >> >> Sure. The kbuild report up thread has some or most of them. >> >> But here's a full list: >> >> Failed 279/290 >>

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-12 Thread Gustavo A. R. Silva
On 10/12/18 11:32 AM, Michael Ellerman wrote: > > Sure. The kbuild report up thread has some or most of them. > > But here's a full list: > > Failed 279/290 > http://kisskb.ellerman.id.au/kisskb/head/1d59e2c78793d8aea9949ca71323c4583c78f488/ > Failed:

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-12 Thread Michael Ellerman
"Gustavo A. R. Silva" writes: > Hi Michael, > > On 10/11/18 2:32 AM, Michael Ellerman wrote: > >> It still pops a few errors, including in linux/signal.h & compat.h, so >> it's somewhat aspirational until we can get those fixed up :) >> > > I wonder if you have a log containing those warnings

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-11 Thread Gustavo A. R. Silva
Hi Michael, On 10/11/18 2:32 AM, Michael Ellerman wrote: > It still pops a few errors, including in linux/signal.h & compat.h, so > it's somewhat aspirational until we can get those fixed up :) > I wonder if you have a log containing those warnings that you can share with me. I'd like to fix

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-11 Thread Gustavo A. R. Silva
On 10/11/18 3:35 AM, Kees Cook wrote: > On Wed, Oct 10, 2018 at 5:32 PM, Michael Ellerman wrote: >> Kees Cook writes: >>> On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman >>> wrote: Warn whenever a switch statement has a fallthrough without a comment annotating it.

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-10 Thread Kees Cook
On Wed, Oct 10, 2018 at 5:32 PM, Michael Ellerman wrote: > Kees Cook writes: >> On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman >> wrote: >>> Warn whenever a switch statement has a fallthrough without a comment >>> annotating it. >>> >>> Signed-off-by: Michael Ellerman >> >> Yes please. :)

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-10 Thread Michael Ellerman
Kees Cook writes: > On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman wrote: >> Warn whenever a switch statement has a fallthrough without a comment >> annotating it. >> >> Signed-off-by: Michael Ellerman > > Yes please. :) > > Reviewed-by: Kees Cook Haha, thanks. It still pops a few errors,

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-10 Thread kbuild test robot
Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.19-rc7 next-20181010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-10 Thread kbuild test robot
Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.19-rc7 next-20181010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-10 Thread Kees Cook
On Tue, Oct 9, 2018 at 10:13 PM, Michael Ellerman wrote: > Warn whenever a switch statement has a fallthrough without a comment > annotating it. > > Signed-off-by: Michael Ellerman Yes please. :) Reviewed-by: Kees Cook -Kees > --- > arch/powerpc/Kbuild | 1 + > 1 file changed, 1

[PATCH 4/4] powerpc: Add -Wimplicit-fallthrough to arch CFLAGS

2018-10-09 Thread Michael Ellerman
Warn whenever a switch statement has a fallthrough without a comment annotating it. Signed-off-by: Michael Ellerman --- arch/powerpc/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/Kbuild b/arch/powerpc/Kbuild index 86b261d6bde5..ef625f1db576 100644 ---