Re: [PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-12-02 Thread Jeff Garzik
On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote: In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap-ops-bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which the generic sff one isn't suitable Signed-off-by:

[PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-12-01 Thread Benjamin Herrenschmidt
In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap-ops-bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which the generic sff one isn't suitable Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org ---

[PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-11-30 Thread Benjamin Herrenschmidt
In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap-ops-bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which the generic sff one isn't suitable Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org ---

Re: [PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-11-30 Thread Tejun Heo
On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap-ops-bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which the generic sff one isn't suitable Signed-off-by:

Re: [PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-11-30 Thread Benjamin Herrenschmidt
On Tue, 2009-12-01 at 16:25 +0900, Tejun Heo wrote: On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap-ops-bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which

Re: [PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-11-30 Thread Tejun Heo
On 12/01/2009 04:29 PM, Benjamin Herrenschmidt wrote: On Tue, 2009-12-01 at 16:25 +0900, Tejun Heo wrote: On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap-ops-bmdma_stop(). This can be a problem for

Re: [PATCH 4/5] libata/sff: Use ops-bmdma_stop instead of ata_bmdma_stop()

2009-11-30 Thread Benjamin Herrenschmidt
On Tue, 2009-12-01 at 16:33 +0900, Tejun Heo wrote: Feel free to pick that one up earlier if you want (ie for 2.6.32), as long as we manage to get it in in 2.6.33 -before- I push powerpc-next to Linus, I'm happy :-) (or we can have it in both trees). As nasty as the bug might be, given