Re: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

2018-10-19 Thread Christoph Hellwig
On Fri, Oct 19, 2018 at 02:07:04PM +0900, Masahiro Yamada wrote: > We could add 'depends on HAVE_PCI' or something > to guard it to avoid changing the logic. I guess that makes sense. > config PCI_ENDPOINT > bool "PCI Endpoint Support" > depends on HAVE_PCI # Is this correct

Re: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

2018-10-18 Thread Max Filippov
Hi Christoph, On Wed, Oct 17, 2018 at 1:03 AM Christoph Hellwig wrote: > diff --git a/arch/xtensa/configs/iss_defconfig > b/arch/xtensa/configs/iss_defconfig > index 4bb5b76d9524..818849bb7736 100644 > --- a/arch/xtensa/configs/iss_defconfig > +++ b/arch/xtensa/configs/iss_defconfig > @@ -4,7

Re: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

2018-10-18 Thread Masahiro Yamada
On Wed, Oct 17, 2018 at 5:04 PM Christoph Hellwig wrote: > > There is no good reason to duplicate the PCI menu in every architecture. > Instead provide a selectable HAS_PCI symbol that indicates availability HAS_PCI -> HAVE_PCI > of PCI support and the handle the rest in drivers/pci. > > Note

[PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

2018-10-17 Thread Christoph Hellwig
There is no good reason to duplicate the PCI menu in every architecture. Instead provide a selectable HAS_PCI symbol that indicates availability of PCI support and the handle the rest in drivers/pci. Note that for powerpc we now select HAVE_PCI globally instead of the convoluted mess of

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-15 Thread Bjorn Helgaas
s/^pci: /PCI: / in subject On Sat, Oct 13, 2018 at 05:10:12PM +0200, Christoph Hellwig wrote: > There is no good reason to duplicate the PCI menu in every architecture. > Instead provide a selectable HAS_PCI symbol that indicates availability > of PCI support and the handle the rest in

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-15 Thread Masahiro Yamada
On Mon, Oct 15, 2018 at 5:57 PM Christoph Hellwig wrote: > > On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote: > > I think HAVE_ is a preferred prefix in this case according to this doc: > >

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-15 Thread Christoph Hellwig
On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote: > I think HAVE_ is a preferred prefix in this case according to this doc: > https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kconfig-language.txt#L448 Ok, I'll switch everything to HAVE_* > If you do this for

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-15 Thread Masahiro Yamada
On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > There is no good reason to duplicate the PCI menu in every architecture. > Instead provide a selectable HAS_PCI symbol that indicates availability > of PCI support and the handle the rest in drivers/pci. I think HAVE_ is a preferred

[PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

2018-10-13 Thread Christoph Hellwig
There is no good reason to duplicate the PCI menu in every architecture. Instead provide a selectable HAS_PCI symbol that indicates availability of PCI support and the handle the rest in drivers/pci. Note that for powerpc we now select HAS_PCI globally instead of the convoluted mess of