On 12/01/2009 07:36 PM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and
Benjamin Herrenschmidt writes:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend/resume. It should
On Thu, 2009-12-03 at 03:12 -0500, Jeff Garzik wrote:
Looks fine to me. Two minor comments, which might perhaps be ignored if
that is your taste:
* prefer enums to #define's, for constants
yeah well ... I lifted those definitions from the old driver and didn't
feel like changing them all
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
v2. Better tested now, seems to be reasonably solid.
Addressed Tejun comments and made remove more robust vs. media-bay,
should also fix Andreas problem.
Thanks, this works fine now, including suspend *and* resume. :-)
Andreas.
--
(cc'ing Holger Macht, please read the comment below pata_macio_mb_event())
Hello,
On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
Don't know
On Tue, 2009-12-01 at 11:48 +0100, Mikael Pettersson wrote:
Thanks for reviving pata_macio.
Does the new version work with yaboot? (the previous one didn't)
Well, yaboot itself should have no problem. However, the ybin script
that automagically finds the right OF path might indeed still be
Benjamin Herrenschmidt writes:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend/resume. It should
On 12/01/2009 09:44 PM, Holger Macht wrote:
I do not remember any specific reason for using ata_port_schedule_eh(). I
guess it's just there because the previous implementation used
it. ata_port_freeze()/abort() might as well work properly. However, I
would hesitate to change the existing code,
On Tuesday 01 December 2009 09:00:34 Tejun Heo wrote:
(cc'ing Holger Macht, please read the comment below pata_macio_mb_event())
Hello,
On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks.
On Tue, 2009-12-01 at 21:43 +0100, Andreas Schwab wrote:
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
Tried it on my iBook G4 and
On Tue, 2009-12-01 at 21:43 +0100, Andreas Schwab wrote:
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
Tried it on my iBook G4 and
On Tue, 2009-12-01 at 17:00 +0900, Tejun Heo wrote:
+#define IDE_WAKEUP_DELAY (1*HZ)
nitpick: In libata, it's common to use msecs for timing values so that
might be a better option.
Yeah, that's cruft lifted from the old driver, I'll fix it.
+static const struct pata_macio_timing
Hello,
On 12/02/2009 08:19 AM, Benjamin Herrenschmidt wrote:
I think you'll need an ata_port_freeze() or abort() here because at
this point the drive is already gone and all in-flight commands need
to be failed right away. Holger, do you remember why
ata_acpi_detach_device() is using
On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote:
Conceptually freeze would be more approriate but the side effect is
that the port is frozen and EH will try to thaw it by resetting it.
So, abort would work better.
BTW. For a plug event, what should I do ? freeze is fine ? Or just
schedule
On 12/02/2009 08:35 AM, Benjamin Herrenschmidt wrote:
On Wed, 2009-12-02 at 08:27 +0900, Tejun Heo wrote:
Conceptually freeze would be more approriate but the side effect is
that the port is frozen and EH will try to thaw it by resetting it.
So, abort would work better.
BTW. For a plug
On Wed, 2009-12-02 at 08:44 +0900, Tejun Heo wrote:
BTW. For a plug event, what should I do ? freeze is fine ? Or just
schedule eh ? Right now, when plugging I see an exception Emask 0x10
etc... message in the log when plugging which isn't totally nice :-)
freeze() and please don't fight
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend/resume. It should also support module load/unload.
The
On 12/02/2009 09:36 AM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and
On Wed, 2009-12-02 at 10:07 +0900, Tejun Heo wrote:
On 12/02/2009 09:36 AM, Benjamin Herrenschmidt wrote:
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of
Hello,
On 12/02/2009 10:51 AM, Benjamin Herrenschmidt wrote:
I'm not sure what media bay locking problem you mentioned tho...
The way the driver does the locking now is that I block the media-bay
thread (lock/unlock_media_bay calls) around initial registration and
driver removal which
This is a libata driver for the macio IDE controller used on most Apple
PowerMac and PowerBooks. It's a libata equivalent of drivers/ide/ppc/pmac.c
It supports all the features of its predecessor, including mediabay hotplug
and suspend/resume. It should also support module load/unload.
The
21 matches
Mail list logo
