Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-28 Thread Paul E. McKenney
On Tue, May 28, 2019 at 03:00:07PM -0400, Joel Fernandes wrote: > On Tue, May 28, 2019 at 05:24:47AM -0700, Paul E. McKenney wrote: > > On Sat, May 25, 2019 at 02:14:07PM -0400, Joel Fernandes wrote: > > > On Sat, May 25, 2019 at 08:50:35AM -0700, Paul E. McKenney wrote: > > > > On Sat, May 25, 201

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-28 Thread Joel Fernandes
On Tue, May 28, 2019 at 05:24:47AM -0700, Paul E. McKenney wrote: > On Sat, May 25, 2019 at 02:14:07PM -0400, Joel Fernandes wrote: > > On Sat, May 25, 2019 at 08:50:35AM -0700, Paul E. McKenney wrote: > > > On Sat, May 25, 2019 at 10:19:54AM -0400, Joel Fernandes wrote: > > > > On Sat, May 25, 201

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-28 Thread Paul E. McKenney
On Sat, May 25, 2019 at 02:14:07PM -0400, Joel Fernandes wrote: > On Sat, May 25, 2019 at 08:50:35AM -0700, Paul E. McKenney wrote: > > On Sat, May 25, 2019 at 10:19:54AM -0400, Joel Fernandes wrote: > > > On Sat, May 25, 2019 at 07:08:26AM -0400, Steven Rostedt wrote: > > > > On Sat, 25 May 2019 0

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-25 Thread Joel Fernandes
On Sat, May 25, 2019 at 02:14:07PM -0400, Joel Fernandes wrote: [snip] > > That aside, if we are going to change the name of an API that is > > used 160 places throughout the tree, we would need to have a pretty > > good justification. Without such a justification, it will just look > > like point

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-25 Thread Joel Fernandes
On Sat, May 25, 2019 at 08:50:35AM -0700, Paul E. McKenney wrote: > On Sat, May 25, 2019 at 10:19:54AM -0400, Joel Fernandes wrote: > > On Sat, May 25, 2019 at 07:08:26AM -0400, Steven Rostedt wrote: > > > On Sat, 25 May 2019 04:14:44 -0400 > > > Joel Fernandes wrote: > > > > > > > > I guess the

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-25 Thread Paul E. McKenney
On Sat, May 25, 2019 at 10:19:54AM -0400, Joel Fernandes wrote: > On Sat, May 25, 2019 at 07:08:26AM -0400, Steven Rostedt wrote: > > On Sat, 25 May 2019 04:14:44 -0400 > > Joel Fernandes wrote: > > > > > > I guess the difference between the _raw_notrace and just _raw variants > > > > is that _no

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-25 Thread Joel Fernandes
On Sat, May 25, 2019 at 07:08:26AM -0400, Steven Rostedt wrote: > On Sat, 25 May 2019 04:14:44 -0400 > Joel Fernandes wrote: > > > > I guess the difference between the _raw_notrace and just _raw variants > > > is that _notrace ones do a rcu_check_sparse(). Don't we want to keep > > > that check?

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-25 Thread Steven Rostedt
On Sat, 25 May 2019 04:14:44 -0400 Joel Fernandes wrote: > > I guess the difference between the _raw_notrace and just _raw variants > > is that _notrace ones do a rcu_check_sparse(). Don't we want to keep > > that check? > > This is true. > > Since the users of _raw_notrace are very few, is i

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-25 Thread Joel Fernandes
On Fri, May 24, 2019 at 11:24:58PM -0400, Steven Rostedt wrote: > On Fri, 24 May 2019 19:49:28 -0400 > "Joel Fernandes (Google)" wrote: > > > The series removes users of the following APIs, and the APIs themselves, > > since > > the regular non - _notrace variants don't do any tracing anyway. >

Re: [PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-24 Thread Steven Rostedt
On Fri, 24 May 2019 19:49:28 -0400 "Joel Fernandes (Google)" wrote: > The series removes users of the following APIs, and the APIs themselves, since > the regular non - _notrace variants don't do any tracing anyway. > * hlist_for_each_entry_rcu_notrace > * rcu_dereference_raw_notrace > I gues

[PATCH RFC 0/5] Remove some notrace RCU APIs

2019-05-24 Thread Joel Fernandes (Google)
The series removes users of the following APIs, and the APIs themselves, since the regular non - _notrace variants don't do any tracing anyway. * hlist_for_each_entry_rcu_notrace * rcu_dereference_raw_notrace Joel Fernandes (Google) (5): powerpc: Use regular rcu_dereference_raw API trace: Use re