Re: [PATCH RFC 6/7] arm64: kexec: no need to ClearPageReserved()

[James Morse]

Hi David,

(CC: +Akashi)

On 05/12/2018 12:28, David Hildenbrand wrote:
> This will already be done by free_reserved_page().

(will already be -> will be ?)

So it does!


> diff --git a/arch/arm64/kernel/machine_kexec.c 
> b/arch/arm64/kernel/machine_kexec.c
> index 922add8adb74..0ef4ea73aa54 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
> @@ -353,7 +353,6 @@ void crash_free_reserved_phys_range(unsigned long begin, 
> unsigned long end)
>  
>   for (addr = begin; addr < end; addr += PAGE_SIZE) {
>   page = phys_to_page(addr);
> - ClearPageReserved(page);
>   free_reserved_page(page);
>   }
>  }
> 

Acked-by: James Morse 


Thanks,

James

[PATCH RFC 6/7] arm64: kexec: no need to ClearPageReserved()

[David Hildenbrand]

This will already be done by free_reserved_page().

Cc: Catalin Marinas 
Cc: Will Deacon 
Cc: Bhupesh Sharma 
Cc: James Morse 
Cc: Marc Zyngier 
Cc: Dave Kleikamp 
Cc: Mark Rutland 
Cc: Andrew Morton 
Cc: Michal Hocko 
Cc: Matthew Wilcox 
Signed-off-by: David Hildenbrand 
---
 arch/arm64/kernel/machine_kexec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/kernel/machine_kexec.c 
b/arch/arm64/kernel/machine_kexec.c
index 922add8adb74..0ef4ea73aa54 100644
--- a/arch/arm64/kernel/machine_kexec.c
+++ b/arch/arm64/kernel/machine_kexec.c
@@ -353,7 +353,6 @@ void crash_free_reserved_phys_range(unsigned long begin, 
unsigned long end)
 
for (addr = begin; addr < end; addr += PAGE_SIZE) {
page = phys_to_page(addr);
-   ClearPageReserved(page);
free_reserved_page(page);
}
 }
-- 
2.17.2