RE: [EXT] Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break

2019-04-10 Thread S.j. Wang
Hi Mark > > On Wed, Apr 10, 2019 at 02:42:45AM +, S.j. Wang wrote: > > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent > of > > each other, so replace fall-through with break. > > This doesn't apply against current code, please check and resend. Thanks, have sent v4 for

RE: [EXT] Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break

2019-04-10 Thread S.j. Wang
Hi > > > On 4/9/19 9:42 PM, S.j. Wang wrote: > > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent > of > > each other, so replace fall-through with break. > > > I think you should change the subject line to: > > fix missing break in switch statement > > ...because you are

Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break

2019-04-10 Thread Gustavo A. R. Silva
On 4/9/19 9:42 PM, S.j. Wang wrote: > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of > each other, so replace fall-through with break. > I think you should change the subject line to: fix missing break in switch statement ...because you are fixing a bug, and it's

Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break

2019-04-10 Thread Mark Brown
On Wed, Apr 10, 2019 at 02:42:45AM +, S.j. Wang wrote: > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of > each other, so replace fall-through with break. This doesn't apply against current code, please check and resend. signature.asc Description: PGP signature

Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break

2019-04-09 Thread Nicolin Chen
On Wed, Apr 10, 2019 at 02:42:45AM +, S.j. Wang wrote: > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of > each other, so replace fall-through with break. > > Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") > > Signed-off-by: Shengjiu Wang Acked-by:

[PATCH V2] ASoC: fsl_esai: replace fall-through with break

2019-04-09 Thread S.j. Wang
case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of each other, so replace fall-through with break. Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Signed-off-by: Shengjiu Wang --- Changes in v2 - fix the fixes tag. sound/soc/fsl/fsl_esai.c | 2 +- 1 file