Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Sun, Sep 3, 2017 at 4:32 AM, Haren Myneni wrote: > On 09/02/2017 09:17 AM, Dan Streetman wrote: >> On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni >> wrote: >>> On 08/29/2017 06:58 AM, Dan Streetman wrote: On Sat, Jul 22, 2017 at 1:01 AM,

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 09/02/2017 09:17 AM, Dan Streetman wrote: > On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni wrote: >> On 08/29/2017 06:58 AM, Dan Streetman wrote: >>> On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni >>> wrote: This patch adds P9 NX

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Sat, Sep 2, 2017 at 4:40 AM, Haren Myneni wrote: > On 08/29/2017 06:58 AM, Dan Streetman wrote: >> On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni >> wrote: >>> >>> This patch adds P9 NX support for 842 compression engine. Virtual >>>

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Fri, Sep 1, 2017 at 7:29 AM, Michael Ellerman wrote: > Hi Dan, > > Thanks for reviewing this series. > > Dan Streetman writes: >> On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni >> wrote: >>> On 08/29/2017 02:23 PM, Benjamin

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

> > > +static int nx842_powernv_crypto_init_vas(struct crypto_tfm *tfm) > > > +{ > > > +   struct nx842_crypto_ctx *ctx = crypto_tfm_ctx(tfm); > > > +   struct nx842_workmem *wmem; > > > +   struct nx842_coproc *coproc; > > > +   int ret; > > > + > > > +   ret =

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 08/29/2017 06:58 AM, Dan Streetman wrote: > On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni > wrote: >> >> This patch adds P9 NX support for 842 compression engine. Virtual >> Accelerator Switchboard (VAS) is used to access 842 engine on P9. >> >> For each NX engine

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 09/01/2017 04:34 AM, Michael Ellerman wrote: > Haren Myneni writes: >>> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman >>> wrote: Hi Haren, Some comments inline ... Haren Myneni writes:

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 09/01/2017 04:29 AM, Michael Ellerman wrote: > Hi Dan, > > Thanks for reviewing this series. > > Dan Streetman writes: >> On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni >> wrote: >>> On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: On

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Haren Myneni writes: >> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman >> wrote: >>> Hi Haren, >>> >>> Some comments inline ... >>> >>> Haren Myneni writes: >>> diff --git a/drivers/crypto/nx/nx-842-powernv.c

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Hi Dan, Thanks for reviewing this series. Dan Streetman writes: > On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni > wrote: >> On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >>> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: > +

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 08/31/2017 06:31 AM, Dan Streetman wrote: > On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni > wrote: >> On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >>> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: > + > + ret = -EINVAL; > +

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 08/31/2017 06:40 AM, Dan Streetman wrote: > On Thu, Aug 31, 2017 at 3:44 AM, Haren Myneni > wrote: >> Thanks MIchael and Dan for your review comments. >> >> >> On 08/29/2017 06:32 AM, Dan Streetman wrote: >>> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Thu, Aug 31, 2017 at 3:44 AM, Haren Myneni wrote: > Thanks MIchael and Dan for your review comments. > > > On 08/29/2017 06:32 AM, Dan Streetman wrote: >> On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman >> wrote: >>> Hi Haren, >>> >>> Some

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Tue, Aug 29, 2017 at 5:54 PM, Haren Myneni wrote: > On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: >> On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: + + ret = -EINVAL; + if (coproc && coproc->vas.rxwin) { +

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Thanks MIchael and Dan for your review comments. On 08/29/2017 06:32 AM, Dan Streetman wrote: > On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman wrote: >> Hi Haren, >> >> Some comments inline ... >> >> Haren Myneni writes: >> >>> diff --git

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 08/29/2017 02:57 PM, Benjamin Herrenschmidt wrote: > On Tue, 2017-08-29 at 14:54 -0700, Haren Myneni wrote: >> Opening send window for each crypto transform (crypto_alloc, >> compression/decompression, ..., crypto_free) so that does not have to >> wait for the previous copy/paste complete. VAS

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Tue, 2017-08-29 at 14:54 -0700, Haren Myneni wrote: > Opening send window for each crypto transform (crypto_alloc, > compression/decompression, ..., crypto_free) so that does not have to > wait for the previous copy/paste complete. VAS will map send and > receive windows, and can cache in send

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On 08/29/2017 02:23 PM, Benjamin Herrenschmidt wrote: > On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: >>> + >>> + ret = -EINVAL; >>> + if (coproc && coproc->vas.rxwin) { >>> + wmem->txwin = nx842_alloc_txwin(coproc); >> >> this is wrong. the workmem is scratch

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Tue, 2017-08-29 at 09:58 -0400, Dan Streetman wrote: > > + > > + ret = -EINVAL; > > + if (coproc && coproc->vas.rxwin) { > > + wmem->txwin = nx842_alloc_txwin(coproc); > > this is wrong. the workmem is scratch memory that's valid only for > the duration of a single

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Sat, Jul 22, 2017 at 1:01 AM, Haren Myneni wrote: > > This patch adds P9 NX support for 842 compression engine. Virtual > Accelerator Switchboard (VAS) is used to access 842 engine on P9. > > For each NX engine per chip, setup receive window using > vas_rx_win_open()

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Mon, Aug 28, 2017 at 7:25 PM, Michael Ellerman wrote: > Hi Haren, > > Some comments inline ... > > Haren Myneni writes: > >> diff --git a/drivers/crypto/nx/nx-842-powernv.c >> b/drivers/crypto/nx/nx-842-powernv.c >> index

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Haren Myneni [ha...@linux.vnet.ibm.com] wrote: > > This patch adds P9 NX support for 842 compression engine. Virtual > Accelerator Switchboard (VAS) is used to access 842 engine on P9. > > For each NX engine per chip, setup receive window using > vas_rx_win_open() which configures RxFIFo with

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

Hi Haren, Some comments inline ... Haren Myneni writes: > diff --git a/drivers/crypto/nx/nx-842-powernv.c > b/drivers/crypto/nx/nx-842-powernv.c > index c0dd4c7e17d3..13089a0b9dfa 100644 > --- a/drivers/crypto/nx/nx-842-powernv.c > +++

Re: [PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

On Fri, Jul 21, 2017 at 10:01:42PM -0700, Haren Myneni wrote: > > This patch adds P9 NX support for 842 compression engine. Virtual > Accelerator Switchboard (VAS) is used to access 842 engine on P9. > > For each NX engine per chip, setup receive window using > vas_rx_win_open() which configures

[PATCH V3 6/6] crypto/nx: Add P9 NX support for 842 compression engine

This patch adds P9 NX support for 842 compression engine. Virtual Accelerator Switchboard (VAS) is used to access 842 engine on P9. For each NX engine per chip, setup receive window using vas_rx_win_open() which configures RxFIFo with FIFO address, lpid, pid and tid values. This unique (lpid,