Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-13 Thread Masahiro Yamada
On Wed, May 12, 2021 at 7:29 PM Segher Boessenkool wrote: > > On Wed, May 12, 2021 at 01:48:53PM +1000, Alexey Kardashevskiy wrote: > > >Oh! I completely missed those few lines. Sorry for that :-( > > > > Well, I probably should have made it a separate patch anyway, I'll > > repost separately.

Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-12 Thread Segher Boessenkool
On Wed, May 12, 2021 at 01:48:53PM +1000, Alexey Kardashevskiy wrote: > >Oh! I completely missed those few lines. Sorry for that :-( > > Well, I probably should have made it a separate patch anyway, I'll > repost separately. Thanks. > >To compensate a bit: > > > >>It still puzzles me why we

Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-11 Thread Alexey Kardashevskiy
On 11 May 2021 21:24:55 Segher Boessenkool wrote: Hi! On Tue, May 11, 2021 at 02:48:12PM +1000, Alexey Kardashevskiy wrote: --- a/arch/powerpc/kernel/vdso32/Makefile +++ b/arch/powerpc/kernel/vdso32/Makefile @@ -44,7 +44,7 @@ asflags-y := -D__VDSO32__ -s obj-y += vdso32_wrapper.o targets

Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-11 Thread Alexey Kardashevskiy
On 5/12/21 05:18, Nathan Chancellor wrote: On 5/10/2021 9:48 PM, Alexey Kardashevskiy wrote: The $(CPP) (do only preprocessing) macro is already defined in Makefile. However POWERPC redefines it and adds $(KBUILD_CFLAGS) which results in flags duplication. Which is not a big deal by itself

Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-11 Thread Alexey Kardashevskiy
On 5/12/21 09:16, Segher Boessenkool wrote: On Tue, May 11, 2021 at 11:30:17PM +1000, Alexey Kardashevskiy wrote: In any case, please mention the reasoning (and the fact that you are removing these flags!) in the commit message. Thanks! but i did mention this, the last paragraph... they

Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-11 Thread Segher Boessenkool
On Tue, May 11, 2021 at 11:30:17PM +1000, Alexey Kardashevskiy wrote: > >In any case, please mention the reasoning (and the fact that you are > >removing these flags!) in the commit message. Thanks! > > but i did mention this, the last paragraph... they are duplicated. Oh! I completely missed

Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-11 Thread Nathan Chancellor
On 5/10/2021 9:48 PM, Alexey Kardashevskiy wrote: The $(CPP) (do only preprocessing) macro is already defined in Makefile. However POWERPC redefines it and adds $(KBUILD_CFLAGS) which results in flags duplication. Which is not a big deal by itself except for the flags which depend on other flags

Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-11 Thread Segher Boessenkool
Hi! On Tue, May 11, 2021 at 02:48:12PM +1000, Alexey Kardashevskiy wrote: > --- a/arch/powerpc/kernel/vdso32/Makefile > +++ b/arch/powerpc/kernel/vdso32/Makefile > @@ -44,7 +44,7 @@ asflags-y := -D__VDSO32__ -s > > obj-y += vdso32_wrapper.o > targets += vdso32.lds > -CPPFLAGS_vdso32.lds += -P

[PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

2021-05-10 Thread Alexey Kardashevskiy
The $(CPP) (do only preprocessing) macro is already defined in Makefile. However POWERPC redefines it and adds $(KBUILD_CFLAGS) which results in flags duplication. Which is not a big deal by itself except for the flags which depend on other flags and the compiler checks them as it parses the