Re: [PATCH kernel v2] powerpc/xive: Drop deregistered irqs

2019-07-16 Thread Michael Ellerman
Cédric Le Goater writes: > On 16/07/2019 11:10, Alexey Kardashevskiy wrote: >> On 16/07/2019 18:59, Cédric Le Goater wrote: >>> On 15/07/2019 09:11, Alexey Kardashevskiy wrote: There is a race between releasing an irq on one cpu and fetching it from XIVE on another cpu as there does not

Re: [PATCH kernel v2] powerpc/xive: Drop deregistered irqs

2019-07-16 Thread Cédric Le Goater
On 15/07/2019 09:11, Alexey Kardashevskiy wrote: > There is a race between releasing an irq on one cpu and fetching it > from XIVE on another cpu as there does not seem to be any locking between > these, probably because xive_irq_chip::irq_shutdown() is supposed to > remove the irq from all queues

Re: [PATCH kernel v2] powerpc/xive: Drop deregistered irqs

2019-07-16 Thread Cédric Le Goater
On 16/07/2019 11:10, Alexey Kardashevskiy wrote: > > > On 16/07/2019 18:59, Cédric Le Goater wrote: >> On 15/07/2019 09:11, Alexey Kardashevskiy wrote: >>> There is a race between releasing an irq on one cpu and fetching it >>> from XIVE on another cpu as there does not seem to be any locking

Re: [PATCH kernel v2] powerpc/xive: Drop deregistered irqs

2019-07-16 Thread Alexey Kardashevskiy
On 16/07/2019 18:59, Cédric Le Goater wrote: On 15/07/2019 09:11, Alexey Kardashevskiy wrote: There is a race between releasing an irq on one cpu and fetching it from XIVE on another cpu as there does not seem to be any locking between these, probably because xive_irq_chip::irq_shutdown() is

[PATCH kernel v2] powerpc/xive: Drop deregistered irqs

2019-07-15 Thread Alexey Kardashevskiy
There is a race between releasing an irq on one cpu and fetching it from XIVE on another cpu as there does not seem to be any locking between these, probably because xive_irq_chip::irq_shutdown() is supposed to remove the irq from all queues in the system which it does not do. As a result, when