Re: [PATCH kernel v4 2/4] powerpc/iommu: Allow bypass-only for DMA

2019-07-15 Thread Christoph Hellwig
On Mon, Jul 15, 2019 at 06:33:00PM +1000, Alexey Kardashevskiy wrote: > > > On 13/07/2019 01:20, Christoph Hellwig wrote: > > > This skips the 32bit DMA setup check if the bypass is can be selected. > > > > That sentence does not parse. I think you need to dop the "can be" > > based on the

Re: [PATCH kernel v4 2/4] powerpc/iommu: Allow bypass-only for DMA

2019-07-15 Thread Alexey Kardashevskiy
On 13/07/2019 01:20, Christoph Hellwig wrote: This skips the 32bit DMA setup check if the bypass is can be selected. That sentence does not parse. I think you need to dop the "can be" based on the actual patch. "the 32bit DMA setup check" is "if (!(tbl = get_iommu_table_base(dev)))". I

Re: [PATCH kernel v4 2/4] powerpc/iommu: Allow bypass-only for DMA

2019-07-12 Thread Christoph Hellwig
> This skips the 32bit DMA setup check if the bypass is can be selected. That sentence does not parse. I think you need to dop the "can be" based on the actual patch.

[PATCH kernel v4 2/4] powerpc/iommu: Allow bypass-only for DMA

2019-07-12 Thread Alexey Kardashevskiy
POWER8 and newer support a bypass mode which maps all host memory to PCI buses so an IOMMU table is not always required. However if we fail to create such a table, the DMA setup fails and the kernel does not boot. This skips the 32bit DMA setup check if the bypass is can be selected.