Re: [PATCH kernel v8 00/10] powerpc/kvm/vfio: Enable in-kernel acceleration

2017-03-14 Thread Alex Williamson 
On Tue, 14 Mar 2017 11:55:33 +1100
David Gibson  wrote:

> On Tue, Mar 14, 2017 at 11:54:03AM +1100, Alexey Kardashevskiy wrote:
> > On 10/03/17 15:48, David Gibson wrote:  
> > > On Fri, Mar 10, 2017 at 02:53:27PM +1100, Alexey Kardashevskiy wrote:  
> > >> This is my current queue of patches to add acceleration of TCE
> > >> updates in KVM.
> > >>
> > >> This is based on Linus'es tree sha1 c1aa905a304e.  

Hmm, sure about that?  03/10 doesn't apply.

> > > 
> > > I think we're finally there - I've now sent an R-b for all patches.  
> > 
> > Thanks for the patience.
> > 
> > 
> > I supposed in order to proceed now I need an ack from Alex, correct?  
> 
> That, or simply for him to merge it.

Given the diffstat, I'd guess you're looking for acks from me and maybe
Paolo, but it looks like it should be merged through ppc trees.  Thanks,

Alex

> > >>
> > >> Please comment. Thanks.
> > >>
> > >> Changes:
> > >> v8:
> > >> * kept fixing oddities with error handling in 10/10
> > >>
> > >> v7:
> > >> * added realmode's WARN_ON_ONCE_RM in arch/powerpc/kvm/book3s_64_vio_hv.c
> > >>
> > >> v6:
> > >> * reworked the last patch in terms of error handling and parameters 
> > >> checking
> > >>
> > >> v5:
> > >> * replaced "KVM: PPC: Separate TCE validation from update" with
> > >> "KVM: PPC: iommu: Unify TCE checking"
> > >> * changed already reviewed "powerpc/iommu/vfio_spapr_tce: Cleanup 
> > >> iommu_table disposal"
> > >> * reworked "KVM: PPC: VFIO: Add in-kernel acceleration for VFIO"
> > >> * more details in individual commit logs
> > >>
> > >> v4:
> > >> * addressed comments from v3
> > >> * updated subject lines with correct component names
> > >> * regrouped the patchset in order:
> > >>  - powerpc fixes;
> > >>  - vfio_spapr_tce driver fixes;
> > >>  - KVM/PPC fixes;
> > >>  - KVM+PPC+VFIO;
> > >> * everything except last 2 patches have "Reviewed-By: David"
> > >>
> > >> v3:
> > >> * there was no full repost, only last patch was posted
> > >>
> > >> v2:
> > >> * 11/11 reworked to use new notifiers, it is rather RFC as it still has
> > >> a issue;
> > >> * got 09/11, 10/11 to use notifiers in 11/11;
> > >> * added rb: David to most of patches and added a comment in 05/11.
> > >>
> > >> Alexey Kardashevskiy (10):
> > >>   powerpc/mmu: Add real mode support for IOMMU preregistered memory
> > >>   powerpc/powernv/iommu: Add real mode version of
> > >> iommu_table_ops::exchange()
> > >>   powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal
> > >>   powerpc/vfio_spapr_tce: Add reference counting to iommu_table
> > >>   KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number
> > >>   KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently
> > >>   KVM: PPC: Pass kvm* to kvmppc_find_table()
> > >>   KVM: PPC: Use preregistered memory API to access TCE list
> > >>   KVM: PPC: iommu: Unify TCE checking
> > >>   KVM: PPC: VFIO: Add in-kernel acceleration for VFIO
> > >>
> > >>  Documentation/virtual/kvm/devices/vfio.txt |  22 +-
> > >>  arch/powerpc/include/asm/iommu.h   |  32 ++-
> > >>  arch/powerpc/include/asm/kvm_host.h|   8 +
> > >>  arch/powerpc/include/asm/kvm_ppc.h |  12 +-
> > >>  arch/powerpc/include/asm/mmu_context.h |   4 +
> > >>  include/uapi/linux/kvm.h   |   9 +
> > >>  arch/powerpc/kernel/iommu.c|  86 +---
> > >>  arch/powerpc/kvm/book3s_64_vio.c   | 330 
> > >> -
> > >>  arch/powerpc/kvm/book3s_64_vio_hv.c| 303 
> > >> ++
> > >>  arch/powerpc/kvm/powerpc.c |   2 +
> > >>  arch/powerpc/mm/mmu_context_iommu.c|  39 
> > >>  arch/powerpc/platforms/powernv/pci-ioda.c  |  46 ++--
> > >>  arch/powerpc/platforms/powernv/pci.c   |   1 +
> > >>  arch/powerpc/platforms/pseries/iommu.c |   3 +-
> > >>  arch/powerpc/platforms/pseries/vio.c   |   2 +-
> > >>  drivers/vfio/vfio_iommu_spapr_tce.c|   2 +-
> > >>  virt/kvm/vfio.c|  60 ++
> > >>  arch/powerpc/kvm/Kconfig   |   1 +
> > >>  18 files changed, 855 insertions(+), 107 deletions(-)
> > >>  
> > >   
> > 
> >   
> 
> 
> 
>

Re: [PATCH kernel v8 00/10] powerpc/kvm/vfio: Enable in-kernel acceleration

2017-03-13 Thread David Gibson 
On Tue, Mar 14, 2017 at 11:54:03AM +1100, Alexey Kardashevskiy wrote:
> On 10/03/17 15:48, David Gibson wrote:
> > On Fri, Mar 10, 2017 at 02:53:27PM +1100, Alexey Kardashevskiy wrote:
> >> This is my current queue of patches to add acceleration of TCE
> >> updates in KVM.
> >>
> >> This is based on Linus'es tree sha1 c1aa905a304e.
> > 
> > I think we're finally there - I've now sent an R-b for all patches.
> 
> Thanks for the patience.
> 
> 
> I supposed in order to proceed now I need an ack from Alex, correct?

That, or simply for him to merge it.

> 
> 
> > 
> > 
> >>
> >> Please comment. Thanks.
> >>
> >> Changes:
> >> v8:
> >> * kept fixing oddities with error handling in 10/10
> >>
> >> v7:
> >> * added realmode's WARN_ON_ONCE_RM in arch/powerpc/kvm/book3s_64_vio_hv.c
> >>
> >> v6:
> >> * reworked the last patch in terms of error handling and parameters 
> >> checking
> >>
> >> v5:
> >> * replaced "KVM: PPC: Separate TCE validation from update" with
> >> "KVM: PPC: iommu: Unify TCE checking"
> >> * changed already reviewed "powerpc/iommu/vfio_spapr_tce: Cleanup 
> >> iommu_table disposal"
> >> * reworked "KVM: PPC: VFIO: Add in-kernel acceleration for VFIO"
> >> * more details in individual commit logs
> >>
> >> v4:
> >> * addressed comments from v3
> >> * updated subject lines with correct component names
> >> * regrouped the patchset in order:
> >>- powerpc fixes;
> >>- vfio_spapr_tce driver fixes;
> >>- KVM/PPC fixes;
> >>- KVM+PPC+VFIO;
> >> * everything except last 2 patches have "Reviewed-By: David"
> >>
> >> v3:
> >> * there was no full repost, only last patch was posted
> >>
> >> v2:
> >> * 11/11 reworked to use new notifiers, it is rather RFC as it still has
> >> a issue;
> >> * got 09/11, 10/11 to use notifiers in 11/11;
> >> * added rb: David to most of patches and added a comment in 05/11.
> >>
> >> Alexey Kardashevskiy (10):
> >>   powerpc/mmu: Add real mode support for IOMMU preregistered memory
> >>   powerpc/powernv/iommu: Add real mode version of
> >> iommu_table_ops::exchange()
> >>   powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal
> >>   powerpc/vfio_spapr_tce: Add reference counting to iommu_table
> >>   KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number
> >>   KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently
> >>   KVM: PPC: Pass kvm* to kvmppc_find_table()
> >>   KVM: PPC: Use preregistered memory API to access TCE list
> >>   KVM: PPC: iommu: Unify TCE checking
> >>   KVM: PPC: VFIO: Add in-kernel acceleration for VFIO
> >>
> >>  Documentation/virtual/kvm/devices/vfio.txt |  22 +-
> >>  arch/powerpc/include/asm/iommu.h   |  32 ++-
> >>  arch/powerpc/include/asm/kvm_host.h|   8 +
> >>  arch/powerpc/include/asm/kvm_ppc.h |  12 +-
> >>  arch/powerpc/include/asm/mmu_context.h |   4 +
> >>  include/uapi/linux/kvm.h   |   9 +
> >>  arch/powerpc/kernel/iommu.c|  86 +---
> >>  arch/powerpc/kvm/book3s_64_vio.c   | 330 
> >> -
> >>  arch/powerpc/kvm/book3s_64_vio_hv.c| 303 
> >> ++
> >>  arch/powerpc/kvm/powerpc.c |   2 +
> >>  arch/powerpc/mm/mmu_context_iommu.c|  39 
> >>  arch/powerpc/platforms/powernv/pci-ioda.c  |  46 ++--
> >>  arch/powerpc/platforms/powernv/pci.c   |   1 +
> >>  arch/powerpc/platforms/pseries/iommu.c |   3 +-
> >>  arch/powerpc/platforms/pseries/vio.c   |   2 +-
> >>  drivers/vfio/vfio_iommu_spapr_tce.c|   2 +-
> >>  virt/kvm/vfio.c|  60 ++
> >>  arch/powerpc/kvm/Kconfig   |   1 +
> >>  18 files changed, 855 insertions(+), 107 deletions(-)
> >>
> > 
> 
> 




-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

Re: [PATCH kernel v8 00/10] powerpc/kvm/vfio: Enable in-kernel acceleration

2017-03-13 Thread Alexey Kardashevskiy 
On 10/03/17 15:48, David Gibson wrote:
> On Fri, Mar 10, 2017 at 02:53:27PM +1100, Alexey Kardashevskiy wrote:
>> This is my current queue of patches to add acceleration of TCE
>> updates in KVM.
>>
>> This is based on Linus'es tree sha1 c1aa905a304e.
> 
> I think we're finally there - I've now sent an R-b for all patches.

Thanks for the patience.


I supposed in order to proceed now I need an ack from Alex, correct?


> 
> 
>>
>> Please comment. Thanks.
>>
>> Changes:
>> v8:
>> * kept fixing oddities with error handling in 10/10
>>
>> v7:
>> * added realmode's WARN_ON_ONCE_RM in arch/powerpc/kvm/book3s_64_vio_hv.c
>>
>> v6:
>> * reworked the last patch in terms of error handling and parameters checking
>>
>> v5:
>> * replaced "KVM: PPC: Separate TCE validation from update" with
>> "KVM: PPC: iommu: Unify TCE checking"
>> * changed already reviewed "powerpc/iommu/vfio_spapr_tce: Cleanup 
>> iommu_table disposal"
>> * reworked "KVM: PPC: VFIO: Add in-kernel acceleration for VFIO"
>> * more details in individual commit logs
>>
>> v4:
>> * addressed comments from v3
>> * updated subject lines with correct component names
>> * regrouped the patchset in order:
>>  - powerpc fixes;
>>  - vfio_spapr_tce driver fixes;
>>  - KVM/PPC fixes;
>>  - KVM+PPC+VFIO;
>> * everything except last 2 patches have "Reviewed-By: David"
>>
>> v3:
>> * there was no full repost, only last patch was posted
>>
>> v2:
>> * 11/11 reworked to use new notifiers, it is rather RFC as it still has
>> a issue;
>> * got 09/11, 10/11 to use notifiers in 11/11;
>> * added rb: David to most of patches and added a comment in 05/11.
>>
>> Alexey Kardashevskiy (10):
>>   powerpc/mmu: Add real mode support for IOMMU preregistered memory
>>   powerpc/powernv/iommu: Add real mode version of
>> iommu_table_ops::exchange()
>>   powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal
>>   powerpc/vfio_spapr_tce: Add reference counting to iommu_table
>>   KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number
>>   KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently
>>   KVM: PPC: Pass kvm* to kvmppc_find_table()
>>   KVM: PPC: Use preregistered memory API to access TCE list
>>   KVM: PPC: iommu: Unify TCE checking
>>   KVM: PPC: VFIO: Add in-kernel acceleration for VFIO
>>
>>  Documentation/virtual/kvm/devices/vfio.txt |  22 +-
>>  arch/powerpc/include/asm/iommu.h   |  32 ++-
>>  arch/powerpc/include/asm/kvm_host.h|   8 +
>>  arch/powerpc/include/asm/kvm_ppc.h |  12 +-
>>  arch/powerpc/include/asm/mmu_context.h |   4 +
>>  include/uapi/linux/kvm.h   |   9 +
>>  arch/powerpc/kernel/iommu.c|  86 +---
>>  arch/powerpc/kvm/book3s_64_vio.c   | 330 
>> -
>>  arch/powerpc/kvm/book3s_64_vio_hv.c| 303 ++
>>  arch/powerpc/kvm/powerpc.c |   2 +
>>  arch/powerpc/mm/mmu_context_iommu.c|  39 
>>  arch/powerpc/platforms/powernv/pci-ioda.c  |  46 ++--
>>  arch/powerpc/platforms/powernv/pci.c   |   1 +
>>  arch/powerpc/platforms/pseries/iommu.c |   3 +-
>>  arch/powerpc/platforms/pseries/vio.c   |   2 +-
>>  drivers/vfio/vfio_iommu_spapr_tce.c|   2 +-
>>  virt/kvm/vfio.c|  60 ++
>>  arch/powerpc/kvm/Kconfig   |   1 +
>>  18 files changed, 855 insertions(+), 107 deletions(-)
>>
> 


-- 
Alexey



signature.asc
Description: OpenPGP digital signature

Re: [PATCH kernel v8 00/10] powerpc/kvm/vfio: Enable in-kernel acceleration

2017-03-09 Thread David Gibson 
On Fri, Mar 10, 2017 at 02:53:27PM +1100, Alexey Kardashevskiy wrote:
> This is my current queue of patches to add acceleration of TCE
> updates in KVM.
> 
> This is based on Linus'es tree sha1 c1aa905a304e.

I think we're finally there - I've now sent an R-b for all patches.


> 
> Please comment. Thanks.
> 
> Changes:
> v8:
> * kept fixing oddities with error handling in 10/10
> 
> v7:
> * added realmode's WARN_ON_ONCE_RM in arch/powerpc/kvm/book3s_64_vio_hv.c
> 
> v6:
> * reworked the last patch in terms of error handling and parameters checking
> 
> v5:
> * replaced "KVM: PPC: Separate TCE validation from update" with
> "KVM: PPC: iommu: Unify TCE checking"
> * changed already reviewed "powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table 
> disposal"
> * reworked "KVM: PPC: VFIO: Add in-kernel acceleration for VFIO"
> * more details in individual commit logs
> 
> v4:
> * addressed comments from v3
> * updated subject lines with correct component names
> * regrouped the patchset in order:
>   - powerpc fixes;
>   - vfio_spapr_tce driver fixes;
>   - KVM/PPC fixes;
>   - KVM+PPC+VFIO;
> * everything except last 2 patches have "Reviewed-By: David"
> 
> v3:
> * there was no full repost, only last patch was posted
> 
> v2:
> * 11/11 reworked to use new notifiers, it is rather RFC as it still has
> a issue;
> * got 09/11, 10/11 to use notifiers in 11/11;
> * added rb: David to most of patches and added a comment in 05/11.
> 
> Alexey Kardashevskiy (10):
>   powerpc/mmu: Add real mode support for IOMMU preregistered memory
>   powerpc/powernv/iommu: Add real mode version of
> iommu_table_ops::exchange()
>   powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal
>   powerpc/vfio_spapr_tce: Add reference counting to iommu_table
>   KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number
>   KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently
>   KVM: PPC: Pass kvm* to kvmppc_find_table()
>   KVM: PPC: Use preregistered memory API to access TCE list
>   KVM: PPC: iommu: Unify TCE checking
>   KVM: PPC: VFIO: Add in-kernel acceleration for VFIO
> 
>  Documentation/virtual/kvm/devices/vfio.txt |  22 +-
>  arch/powerpc/include/asm/iommu.h   |  32 ++-
>  arch/powerpc/include/asm/kvm_host.h|   8 +
>  arch/powerpc/include/asm/kvm_ppc.h |  12 +-
>  arch/powerpc/include/asm/mmu_context.h |   4 +
>  include/uapi/linux/kvm.h   |   9 +
>  arch/powerpc/kernel/iommu.c|  86 +---
>  arch/powerpc/kvm/book3s_64_vio.c   | 330 
> -
>  arch/powerpc/kvm/book3s_64_vio_hv.c| 303 ++
>  arch/powerpc/kvm/powerpc.c |   2 +
>  arch/powerpc/mm/mmu_context_iommu.c|  39 
>  arch/powerpc/platforms/powernv/pci-ioda.c  |  46 ++--
>  arch/powerpc/platforms/powernv/pci.c   |   1 +
>  arch/powerpc/platforms/pseries/iommu.c |   3 +-
>  arch/powerpc/platforms/pseries/vio.c   |   2 +-
>  drivers/vfio/vfio_iommu_spapr_tce.c|   2 +-
>  virt/kvm/vfio.c|  60 ++
>  arch/powerpc/kvm/Kconfig   |   1 +
>  18 files changed, 855 insertions(+), 107 deletions(-)
> 

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

[PATCH kernel v8 00/10] powerpc/kvm/vfio: Enable in-kernel acceleration

2017-03-09 Thread Alexey Kardashevskiy 
This is my current queue of patches to add acceleration of TCE
updates in KVM.

This is based on Linus'es tree sha1 c1aa905a304e.

Please comment. Thanks.

Changes:
v8:
* kept fixing oddities with error handling in 10/10

v7:
* added realmode's WARN_ON_ONCE_RM in arch/powerpc/kvm/book3s_64_vio_hv.c

v6:
* reworked the last patch in terms of error handling and parameters checking

v5:
* replaced "KVM: PPC: Separate TCE validation from update" with
"KVM: PPC: iommu: Unify TCE checking"
* changed already reviewed "powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table 
disposal"
* reworked "KVM: PPC: VFIO: Add in-kernel acceleration for VFIO"
* more details in individual commit logs

v4:
* addressed comments from v3
* updated subject lines with correct component names
* regrouped the patchset in order:
- powerpc fixes;
- vfio_spapr_tce driver fixes;
- KVM/PPC fixes;
- KVM+PPC+VFIO;
* everything except last 2 patches have "Reviewed-By: David"

v3:
* there was no full repost, only last patch was posted

v2:
* 11/11 reworked to use new notifiers, it is rather RFC as it still has
a issue;
* got 09/11, 10/11 to use notifiers in 11/11;
* added rb: David to most of patches and added a comment in 05/11.

Alexey Kardashevskiy (10):
  powerpc/mmu: Add real mode support for IOMMU preregistered memory
  powerpc/powernv/iommu: Add real mode version of
iommu_table_ops::exchange()
  powerpc/iommu/vfio_spapr_tce: Cleanup iommu_table disposal
  powerpc/vfio_spapr_tce: Add reference counting to iommu_table
  KVM: PPC: Reserve KVM_CAP_SPAPR_TCE_VFIO capability number
  KVM: PPC: Enable IOMMU_API for KVM_BOOK3S_64 permanently
  KVM: PPC: Pass kvm* to kvmppc_find_table()
  KVM: PPC: Use preregistered memory API to access TCE list
  KVM: PPC: iommu: Unify TCE checking
  KVM: PPC: VFIO: Add in-kernel acceleration for VFIO

 Documentation/virtual/kvm/devices/vfio.txt |  22 +-
 arch/powerpc/include/asm/iommu.h   |  32 ++-
 arch/powerpc/include/asm/kvm_host.h|   8 +
 arch/powerpc/include/asm/kvm_ppc.h |  12 +-
 arch/powerpc/include/asm/mmu_context.h |   4 +
 include/uapi/linux/kvm.h   |   9 +
 arch/powerpc/kernel/iommu.c|  86 +---
 arch/powerpc/kvm/book3s_64_vio.c   | 330 -
 arch/powerpc/kvm/book3s_64_vio_hv.c| 303 ++
 arch/powerpc/kvm/powerpc.c |   2 +
 arch/powerpc/mm/mmu_context_iommu.c|  39 
 arch/powerpc/platforms/powernv/pci-ioda.c  |  46 ++--
 arch/powerpc/platforms/powernv/pci.c   |   1 +
 arch/powerpc/platforms/pseries/iommu.c |   3 +-
 arch/powerpc/platforms/pseries/vio.c   |   2 +-
 drivers/vfio/vfio_iommu_spapr_tce.c|   2 +-
 virt/kvm/vfio.c|  60 ++
 arch/powerpc/kvm/Kconfig   |   1 +
 18 files changed, 855 insertions(+), 107 deletions(-)

-- 
2.11.0