Re: [PATCH net v2 0/4] ibmvnic: Harden device commands and queries
From: Thomas Falcon Date: Mon, 25 Nov 2019 17:12:52 -0600 > This patch series fixes some shortcomings with the current > VNIC device command implementation. The first patch fixes > the initialization of driver completion structures used > for device commands. Additionally, all waits for device > commands are bounded with a timeout in the event that the > device does not respond or becomes inoperable. Finally, > serialize queries to retain the integrity of device return > codes. > > Changes in v2: > > - included header comment for ibmvnic_wait_for_completion > - removed open-coded loop in patch 3/4, suggested by Jakub > - ibmvnic_wait_for_completion accepts timeout value in milliseconds >instead of jiffies > - timeout calculations cleaned up and completed before wait loop > - included missing mutex_destroy calls, suggested by Jakub > - included comment before mutex declaration Series applied, thanks.
[PATCH net v2 0/4] ibmvnic: Harden device commands and queries
This patch series fixes some shortcomings with the current VNIC device command implementation. The first patch fixes the initialization of driver completion structures used for device commands. Additionally, all waits for device commands are bounded with a timeout in the event that the device does not respond or becomes inoperable. Finally, serialize queries to retain the integrity of device return codes. Changes in v2: - included header comment for ibmvnic_wait_for_completion - removed open-coded loop in patch 3/4, suggested by Jakub - ibmvnic_wait_for_completion accepts timeout value in milliseconds instead of jiffies - timeout calculations cleaned up and completed before wait loop - included missing mutex_destroy calls, suggested by Jakub - included comment before mutex declaration Thomas Falcon (4): ibmvnic: Fix completion structure initialization ibmvnic: Terminate waiting device threads after loss of service ibmvnic: Bound waits for device queries ibmvnic: Serialize device queries drivers/net/ethernet/ibm/ibmvnic.c | 192 +++-- drivers/net/ethernet/ibm/ibmvnic.h | 2 + 2 files changed, 167 insertions(+), 27 deletions(-) -- 2.12.3