Re: [PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3)

2008-01-29 Thread Balbir Singh
* Michael Ellerman <[EMAIL PROTECTED]> [2008-01-30 00:04:58]: > Why do you check !p after assigning to nid? I assume it's because we > might have reached the end of the command line, ie. p == NULL, but we're > still adding memory to the last node? If so it's a it's a little subtle > and deserves a

Re: [PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3)

2008-01-29 Thread Michael Ellerman
On Mon, 2008-01-28 at 18:22 +0530, Balbir Singh wrote: > Hi, Paul, > > Here's version 3 of the patch. I've commented the side-effect of > repeatedly setting node 0 online (as to why that is done) and I've > removed the side effect of not creating memory less nodes > (when we hit the memory limit).

[PATCH powerpc] Fake NUMA emulation for PowerPC (Take 3)

2008-01-28 Thread Balbir Singh
* Paul Mackerras <[EMAIL PROTECTED]> [2008-01-27 22:55:43]: > Balbir Singh writes: > > > Here's a better and more complete fix for the problem. Could you > > please see if it works for you? I tested it on a real NUMA box and it > > seemed to work fine there. > > There are a couple of other chang