Re: [PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Michal Suchánek
On Thu, Mar 19, 2020 at 03:16:03PM +0100, Christophe Leroy wrote: > > > Le 19/03/2020 à 14:35, Andy Shevchenko a écrit : > > On Thu, Mar 19, 2020 at 1:54 PM Michal Suchanek wrote: > > > > > > Merge the 32bit and 64bit version. > > > > > > Halve the check constants on 32bit. > > > > > > Use ST

Re: [PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Christophe Leroy
Le 19/03/2020 à 14:35, Andy Shevchenko a écrit : On Thu, Mar 19, 2020 at 1:54 PM Michal Suchanek wrote: Merge the 32bit and 64bit version. Halve the check constants on 32bit. Use STACK_TOP since it is defined. Passing is_64 is now redundant since is_32bit_task() is used to determine whic

Re: [PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Michal Suchánek
On Thu, Mar 19, 2020 at 03:35:03PM +0200, Andy Shevchenko wrote: > On Thu, Mar 19, 2020 at 1:54 PM Michal Suchanek wrote: > > > > Merge the 32bit and 64bit version. > > > > Halve the check constants on 32bit. > > > > Use STACK_TOP since it is defined. > > > > Passing is_64 is now redundant since i

Re: [PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Andy Shevchenko
On Thu, Mar 19, 2020 at 1:54 PM Michal Suchanek wrote: > > Merge the 32bit and 64bit version. > > Halve the check constants on 32bit. > > Use STACK_TOP since it is defined. > > Passing is_64 is now redundant since is_32bit_task() is used to > determine which callchain variant should be used. Use S

[PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Michal Suchanek
Merge the 32bit and 64bit version. Halve the check constants on 32bit. Use STACK_TOP since it is defined. Passing is_64 is now redundant since is_32bit_task() is used to determine which callchain variant should be used. Use STACK_TOP and is_32bit_task() directly. This removes a page from the va

[PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Michal Suchanek
Merge the 32bit and 64bit version. Halve the check constants on 32bit. Use STACK_TOP since it is defined. Passing is_64 is now redundant since is_32bit_task() is used to determine which callchain variant should be used. Use STACK_TOP and is_32bit_task() directly. This removes a page from the va