Re: [PATCH v13 08/24] selftests/vm: fix the wrong assert in pkey_disable_set()

2018-07-17 Thread Dave Hansen
On 07/17/2018 08:58 AM, Ram Pai wrote: > On Wed, Jun 20, 2018 at 07:47:02AM -0700, Dave Hansen wrote: >> On 06/13/2018 05:44 PM, Ram Pai wrote: >>> If the flag is 0, no bits will be set. Hence we cant expect >>> the resulting bitmap to have a higher value than what it >>> was earlier >> ... >>>

Re: [PATCH v13 08/24] selftests/vm: fix the wrong assert in pkey_disable_set()

2018-07-17 Thread Ram Pai
On Wed, Jun 20, 2018 at 07:47:02AM -0700, Dave Hansen wrote: > On 06/13/2018 05:44 PM, Ram Pai wrote: > > If the flag is 0, no bits will be set. Hence we cant expect > > the resulting bitmap to have a higher value than what it > > was earlier > ... > > if (flags) > > - pkey_assert(rea

Re: [PATCH v13 08/24] selftests/vm: fix the wrong assert in pkey_disable_set()

2018-06-20 Thread Dave Hansen
On 06/13/2018 05:44 PM, Ram Pai wrote: > If the flag is 0, no bits will be set. Hence we cant expect > the resulting bitmap to have a higher value than what it > was earlier ... > if (flags) > - pkey_assert(read_pkey_reg() > orig_pkey_reg); > + pkey_assert(read_pkey_re

[PATCH v13 08/24] selftests/vm: fix the wrong assert in pkey_disable_set()

2018-06-13 Thread Ram Pai
If the flag is 0, no bits will be set. Hence we cant expect the resulting bitmap to have a higher value than what it was earlier. cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(