Re: [PATCH v14 09/22] selftests/vm: fixed bugs in pkey_disable_clear()

2018-07-18 Thread Dave Hansen
On 07/17/2018 06:49 AM, Ram Pai wrote: > instead of clearing the bits, pkey_disable_clear() was setting > the bits. Fixed it. Again, I know these are just selftests, but I'm seeing a real lack of attention to detail with these. Please at least go to the trouble of writing actual changelogs with f

[PATCH v14 09/22] selftests/vm: fixed bugs in pkey_disable_clear()

2018-07-17 Thread Ram Pai
instead of clearing the bits, pkey_disable_clear() was setting the bits. Fixed it. Also fixed a wrong assertion in that function. When bits are cleared, the resulting bit value will be less than the original. This hasn't been a problem so far because this code isn't currently used. cc: Dave Hans