Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards

2008-06-30 Thread Scott Wood
On Mon, Jun 30, 2008 at 02:15:25PM +1000, David Gibson wrote: On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote: Added DMA nodes for the elo/elo-plus DMA engines. Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that its the same as all the other boards.

Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards

2008-06-30 Thread Kumar Gala
On Jun 30, 2008, at 10:35 AM, Scott Wood wrote: On Mon, Jun 30, 2008 at 02:15:25PM +1000, David Gibson wrote: On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote: Added DMA nodes for the elo/elo-plus DMA engines. Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so

Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards

2008-06-30 Thread Scott Wood
Kumar Gala wrote: I believe this comes into play when we have more than one DMA controller and sometimes there are special uses like on 8610. Maybe, though I'd just use a phandle to express that (unless you need to program the number that you're using, rather than just use a specific one).

Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards

2008-06-30 Thread Segher Boessenkool
What's the cell-index in these nodes used to index? Given the confusion there's been about the proper use of this property, a comment indicating which shared registers this is used to index is probably a good idea. There's supposed to be a cell-index in the *channels* to index into the shared

Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards

2008-06-29 Thread David Gibson
On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote: Added DMA nodes for the elo/elo-plus DMA engines. Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that its the same as all the other boards. Signed-off-by: Kumar Gala [EMAIL PROTECTED] [snip] diff --git

[PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards

2008-06-27 Thread Kumar Gala
Added DMA nodes for the elo/elo-plus DMA engines. Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that its the same as all the other boards. Signed-off-by: Kumar Gala [EMAIL PROTECTED] --- Some copy/paste bugs are now fixed (thanks Scott for actually looking at the patch).