Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Tue, Nov 28, 2023 at 08:05:26AM +, Greg KH wrote: > On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > > > With regards to future directions that likely won't work for > > > > > > loosening it: > > > > > > Unfortunately, the .rmeta format itself is not

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-28 Thread Greg KH
On Mon, Nov 27, 2023 at 11:27:07AM -0800, Matthew Maurer wrote: > > > > > > > > > With regards to future directions that likely won't work for > > > > > loosening it: > > > > > Unfortunately, the .rmeta format itself is not stable, so I wouldn't > > > > > want to > > > > > teach genksyms to open

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-27 Thread Matthew Maurer
> > > > > > > With regards to future directions that likely won't work for loosening > > > > it: > > > > Unfortunately, the .rmeta format itself is not stable, so I wouldn't > > > > want to > > > > teach genksyms to open it up and split out the pieces for specific > > > > functions. > > > >

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
On Thu, Nov 23, 2023 at 08:38:45PM +0900, Masahiro Yamada wrote: > On Thu, Nov 23, 2023 at 6:05 PM Greg KH wrote: > > > > On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > > > So, even if you enable CONFIG_MODVERSIONS, > > > > nothing is checked for Rust. > > > > Genksyms

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Masahiro Yamada
On Thu, Nov 23, 2023 at 6:05 PM Greg KH wrote: > > On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > > So, even if you enable CONFIG_MODVERSIONS, > > > nothing is checked for Rust. > > > Genksyms computes a CRC from "int foo", and > > > the module subsystem confirms it is a

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-23 Thread Greg KH
On Wed, Nov 22, 2023 at 01:04:09PM -0800, Matthew Maurer wrote: > > So, even if you enable CONFIG_MODVERSIONS, > > nothing is checked for Rust. > > Genksyms computes a CRC from "int foo", and > > the module subsystem confirms it is a "int" > > variable. > > > > We know this check always succeeds.

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-22 Thread Matthew Maurer
> So, even if you enable CONFIG_MODVERSIONS, > nothing is checked for Rust. > Genksyms computes a CRC from "int foo", and > the module subsystem confirms it is a "int" > variable. > > We know this check always succeeds. > > Why is this useful? The reason this is immediately useful is that it

Re: [PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-22 Thread Masahiro Yamada
On Sat, Nov 18, 2023 at 11:58 AM Matthew Maurer wrote: > > The goal of this patch series is to allow MODVERSIONS and RUST to be > enabled simultaneously. The primary issue with doing this at the moment > is that Rust uses some extremely long symbol names - for those > unfamiliar with Rust, it may

[PATCH v2 0/5] MODVERSIONS + RUST Redux

2023-11-17 Thread Matthew Maurer
The goal of this patch series is to allow MODVERSIONS and RUST to be enabled simultaneously. The primary issue with doing this at the moment is that Rust uses some extremely long symbol names - for those unfamiliar with Rust, it may be helpful to think of some of the mangled C++ names you may have