Re: [PATCH v2 00/14] arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER
On Fri, Mar 24, 2023 at 10:30:07AM -0400, Zi Yan wrote: > On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > Hi, > > > > Several architectures have ARCH_FORCE_MAX_ORDER in their Kconfig and > > they all have wrong and misleading prompt and help text for this option. > > > > Besides, some define insane limits for possible values of > > ARCH_FORCE_MAX_ORDER, some carefully define ranges only for a subset of > > possible configurations, some make this option configurable by users for no > > good reason. > > > > This set updates the prompt and help text everywhere and does its best to > > update actual definitions of ranges where applicable. > > > > kbuild generated a bunch of false positives because it assigns -1 to > > ARCH_FORCE_MAX_ORDER, hopefully this will be fixed soon. > > > > v2: > > * arm64: show prompt for ARCH_FORCE_MAX_ORDER only if EXPERT (Catalin) > > * Add Acked- and Reviewed-by tags (thanks Geert, Kirill and Max) > > > > v1: https://lore.kernel.org/all/20230323092156.2545741-1-r...@kernel.org > > > > Mike Rapoport (IBM) (14): > > arm: reword ARCH_FORCE_MAX_ORDER prompt and help text > > arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER > > arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text > > csky: drop ARCH_FORCE_MAX_ORDER > > ia64: don't allow users to override ARCH_FORCE_MAX_ORDER > > m68k: reword ARCH_FORCE_MAX_ORDER prompt and help text > > nios2: reword ARCH_FORCE_MAX_ORDER prompt and help text > > nios2: drop ranges for definition of ARCH_FORCE_MAX_ORDER > > powerpc: reword ARCH_FORCE_MAX_ORDER prompt and help text > > powerpc: drop ranges for definition of ARCH_FORCE_MAX_ORDER > > sh: reword ARCH_FORCE_MAX_ORDER prompt and help text > > sh: drop ranges for definition of ARCH_FORCE_MAX_ORDER > > sparc: reword ARCH_FORCE_MAX_ORDER prompt and help text > > xtensa: reword ARCH_FORCE_MAX_ORDER prompt and help text > > > > arch/arm/Kconfig | 16 +--- > > arch/arm64/Kconfig| 27 --- > > arch/csky/Kconfig | 4 > > arch/ia64/Kconfig | 3 +-- > > arch/m68k/Kconfig.cpu | 16 +--- > > arch/nios2/Kconfig| 17 + > > arch/powerpc/Kconfig | 22 +- > > arch/sh/mm/Kconfig| 19 +-- > > arch/sparc/Kconfig| 16 +--- > > arch/xtensa/Kconfig | 16 +--- > > 10 files changed, 76 insertions(+), 80 deletions(-) > > > > > > base-commit: 51551d71edbc998fd8c8afa7312db3d270f5998e > > LGTM, thanks. Reviewed-by: Zi Yan Thanks! And thanks for spotting the mistakes in arm64 and sh patches. > -- > Best Regards, > Yan, Zi -- Sincerely yours, Mike.
Re: [PATCH v2 00/14] arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER
On 24 Mar 2023, at 1:22, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Hi, > > Several architectures have ARCH_FORCE_MAX_ORDER in their Kconfig and > they all have wrong and misleading prompt and help text for this option. > > Besides, some define insane limits for possible values of > ARCH_FORCE_MAX_ORDER, some carefully define ranges only for a subset of > possible configurations, some make this option configurable by users for no > good reason. > > This set updates the prompt and help text everywhere and does its best to > update actual definitions of ranges where applicable. > > kbuild generated a bunch of false positives because it assigns -1 to > ARCH_FORCE_MAX_ORDER, hopefully this will be fixed soon. > > v2: > * arm64: show prompt for ARCH_FORCE_MAX_ORDER only if EXPERT (Catalin) > * Add Acked- and Reviewed-by tags (thanks Geert, Kirill and Max) > > v1: https://lore.kernel.org/all/20230323092156.2545741-1-r...@kernel.org > > Mike Rapoport (IBM) (14): > arm: reword ARCH_FORCE_MAX_ORDER prompt and help text > arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER > arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text > csky: drop ARCH_FORCE_MAX_ORDER > ia64: don't allow users to override ARCH_FORCE_MAX_ORDER > m68k: reword ARCH_FORCE_MAX_ORDER prompt and help text > nios2: reword ARCH_FORCE_MAX_ORDER prompt and help text > nios2: drop ranges for definition of ARCH_FORCE_MAX_ORDER > powerpc: reword ARCH_FORCE_MAX_ORDER prompt and help text > powerpc: drop ranges for definition of ARCH_FORCE_MAX_ORDER > sh: reword ARCH_FORCE_MAX_ORDER prompt and help text > sh: drop ranges for definition of ARCH_FORCE_MAX_ORDER > sparc: reword ARCH_FORCE_MAX_ORDER prompt and help text > xtensa: reword ARCH_FORCE_MAX_ORDER prompt and help text > > arch/arm/Kconfig | 16 +--- > arch/arm64/Kconfig| 27 --- > arch/csky/Kconfig | 4 > arch/ia64/Kconfig | 3 +-- > arch/m68k/Kconfig.cpu | 16 +--- > arch/nios2/Kconfig| 17 + > arch/powerpc/Kconfig | 22 +- > arch/sh/mm/Kconfig| 19 +-- > arch/sparc/Kconfig| 16 +--- > arch/xtensa/Kconfig | 16 +--- > 10 files changed, 76 insertions(+), 80 deletions(-) > > > base-commit: 51551d71edbc998fd8c8afa7312db3d270f5998e LGTM, thanks. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi signature.asc Description: OpenPGP digital signature
[PATCH v2 00/14] arch,mm: cleanup Kconfig entries for ARCH_FORCE_MAX_ORDER
From: "Mike Rapoport (IBM)" Hi, Several architectures have ARCH_FORCE_MAX_ORDER in their Kconfig and they all have wrong and misleading prompt and help text for this option. Besides, some define insane limits for possible values of ARCH_FORCE_MAX_ORDER, some carefully define ranges only for a subset of possible configurations, some make this option configurable by users for no good reason. This set updates the prompt and help text everywhere and does its best to update actual definitions of ranges where applicable. kbuild generated a bunch of false positives because it assigns -1 to ARCH_FORCE_MAX_ORDER, hopefully this will be fixed soon. v2: * arm64: show prompt for ARCH_FORCE_MAX_ORDER only if EXPERT (Catalin) * Add Acked- and Reviewed-by tags (thanks Geert, Kirill and Max) v1: https://lore.kernel.org/all/20230323092156.2545741-1-r...@kernel.org Mike Rapoport (IBM) (14): arm: reword ARCH_FORCE_MAX_ORDER prompt and help text arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text csky: drop ARCH_FORCE_MAX_ORDER ia64: don't allow users to override ARCH_FORCE_MAX_ORDER m68k: reword ARCH_FORCE_MAX_ORDER prompt and help text nios2: reword ARCH_FORCE_MAX_ORDER prompt and help text nios2: drop ranges for definition of ARCH_FORCE_MAX_ORDER powerpc: reword ARCH_FORCE_MAX_ORDER prompt and help text powerpc: drop ranges for definition of ARCH_FORCE_MAX_ORDER sh: reword ARCH_FORCE_MAX_ORDER prompt and help text sh: drop ranges for definition of ARCH_FORCE_MAX_ORDER sparc: reword ARCH_FORCE_MAX_ORDER prompt and help text xtensa: reword ARCH_FORCE_MAX_ORDER prompt and help text arch/arm/Kconfig | 16 +--- arch/arm64/Kconfig| 27 --- arch/csky/Kconfig | 4 arch/ia64/Kconfig | 3 +-- arch/m68k/Kconfig.cpu | 16 +--- arch/nios2/Kconfig| 17 + arch/powerpc/Kconfig | 22 +- arch/sh/mm/Kconfig| 19 +-- arch/sparc/Kconfig| 16 +--- arch/xtensa/Kconfig | 16 +--- 10 files changed, 76 insertions(+), 80 deletions(-) base-commit: 51551d71edbc998fd8c8afa7312db3d270f5998e -- 2.35.1 *** BLURB HERE *** Mike Rapoport (IBM) (14): arm: reword ARCH_FORCE_MAX_ORDER prompt and help text arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER arm64: reword ARCH_FORCE_MAX_ORDER prompt and help text csky: drop ARCH_FORCE_MAX_ORDER ia64: don't allow users to override ARCH_FORCE_MAX_ORDER m68k: reword ARCH_FORCE_MAX_ORDER prompt and help text nios2: reword ARCH_FORCE_MAX_ORDER prompt and help text nios2: drop ranges for definition of ARCH_FORCE_MAX_ORDER powerpc: reword ARCH_FORCE_MAX_ORDER prompt and help text powerpc: drop ranges for definition of ARCH_FORCE_MAX_ORDER sh: reword ARCH_FORCE_MAX_ORDER prompt and help text sh: drop ranges for definition of ARCH_FORCE_MAX_ORDER sparc: reword ARCH_FORCE_MAX_ORDER prompt and help text xtensa: reword ARCH_FORCE_MAX_ORDER prompt and help text arch/arm/Kconfig | 16 +--- arch/arm64/Kconfig| 26 -- arch/csky/Kconfig | 4 arch/ia64/Kconfig | 3 +-- arch/m68k/Kconfig.cpu | 16 +--- arch/nios2/Kconfig| 17 + arch/powerpc/Kconfig | 22 +- arch/sh/mm/Kconfig| 19 +-- arch/sparc/Kconfig| 16 +--- arch/xtensa/Kconfig | 16 +--- 10 files changed, 76 insertions(+), 79 deletions(-) base-commit: 51551d71edbc998fd8c8afa7312db3d270f5998e -- 2.35.1
