Re: [PATCH v2 01/14] powerpc/eeh: Remove eeh_dev_phb_init_dynamic()

2020-07-27 Thread Michael Ellerman
Michael Ellerman writes: > On Wed, 22 Jul 2020 14:26:15 +1000, Oliver O'Halloran wrote: >> This function is a one line wrapper around eeh_phb_pe_create() and despite >> the name it doesn't create any eeh_dev structures. Replace it with direct >> calls to eeh_phb_pe_create() since that does what

Re: [PATCH v2 01/14] powerpc/eeh: Remove eeh_dev_phb_init_dynamic()

2020-07-27 Thread Michael Ellerman
On Wed, 22 Jul 2020 14:26:15 +1000, Oliver O'Halloran wrote: > This function is a one line wrapper around eeh_phb_pe_create() and despite > the name it doesn't create any eeh_dev structures. Replace it with direct > calls to eeh_phb_pe_create() since that does what it says on the tin > and removes

Re: [PATCH v2 01/14] powerpc/eeh: Remove eeh_dev_phb_init_dynamic()

2020-07-23 Thread Alexey Kardashevskiy
On 22/07/2020 14:26, Oliver O'Halloran wrote: > This function is a one line wrapper around eeh_phb_pe_create() and despite > the name it doesn't create any eeh_dev structures. The "eeh_dev_phb_init_dynamic" name does not suggest anything really but the comment does. Reviewed-by: Alexey

[PATCH v2 01/14] powerpc/eeh: Remove eeh_dev_phb_init_dynamic()

2020-07-21 Thread Oliver O'Halloran
This function is a one line wrapper around eeh_phb_pe_create() and despite the name it doesn't create any eeh_dev structures. Replace it with direct calls to eeh_phb_pe_create() since that does what it says on the tin and removes a layer of indirection. Signed-off-by: Oliver O'Halloran --- v2: