Re: [PATCH v2 04/10] cxl: Clean up adapter MMIO unmap path.

2015-08-10 Thread Daniel Axtens
Hi Cyril, > > - PCI regions are allocated in cxl_map_adapter_regs. > >Therefore they should be released in unmap, not elsewhere. > > > > You've changed the order in which cxl_remove_adapter() does its work, which, > I'm sure you've considered and it's fine, best to check. Yeah, I have consi

Re: [PATCH v2 04/10] cxl: Clean up adapter MMIO unmap path.

2015-08-10 Thread Cyril Bur
On Tue, 28 Jul 2015 15:28:37 +1000 Daniel Axtens wrote: > - MMIO pointer unmapping is guarded by a null pointer check. >However, iounmap doesn't null the pointer, just invalidate it. >Therefore, explicitly null the pointer after unmapping. > > - afu_desc_mmio also needs to be unmapped.

[PATCH v2 04/10] cxl: Clean up adapter MMIO unmap path.

2015-07-27 Thread Daniel Axtens
- MMIO pointer unmapping is guarded by a null pointer check. However, iounmap doesn't null the pointer, just invalidate it. Therefore, explicitly null the pointer after unmapping. - afu_desc_mmio also needs to be unmapped. - PCI regions are allocated in cxl_map_adapter_regs. Therefore