RE: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan

2015-08-03 Thread Liberman Igal 


Regards,
Igal Liberman.

 -Original Message-
 From: Wood Scott-B07421
 Sent: Thursday, July 30, 2015 11:00 PM
 To: Liberman Igal-B31950
 Cc: devicet...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Bucur
 Madalin-Cristian-B32716; linux-ker...@vger.kernel.org
 Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for
 the FSL QorIQ DPAA FMan
 
 On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote:
  +fman0:  fman@40{
  + #address-cells = 1;
  + #size-cells = 1;
  + cell-index = 0;
  + compatible = fsl,fman;
  + ranges = 0 0x40 0x10;
  + reg = 0x40 0x10;
  + interrupts = 96 2 0 0, 16 2 1 1;
  + clocks = clockgen 3 0;
  + clock-names = fm0clk;
 
 clock-names should be fmanclk as per the binding.  And why would you
 want the driver to have to encode the fman index into the name in order to
 look the clock up by name?
 

Well, yes, this should be fmanclk. The driver doesn't need to know the index.
I'll fix that and re-submit.

Igal.

 -Scott

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan

2015-07-30 Thread Scott Wood 
On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote:
 +fman0:  fman@40{
 + #address-cells = 1;
 + #size-cells = 1;
 + cell-index = 0;
 + compatible = fsl,fman;
 + ranges = 0 0x40 0x10;
 + reg = 0x40 0x10;
 + interrupts = 96 2 0 0, 16 2 1 1;
 + clocks = clockgen 3 0;
 + clock-names = fm0clk;

clock-names should be fmanclk as per the binding.  And why would you want 
the driver to have to encode the fman index into the name in order to look 
the clock up by name?

-Scott

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev