Re: [PATCH v2 12/13] lkdtm: Fix execute_[user]_location()

2021-11-16 Thread Christophe Leroy
Hi Kees, Le 16/10/2021 à 08:42, Christophe Leroy a écrit : Le 15/10/2021 à 23:31, Kees Cook a écrit : On Thu, Oct 14, 2021 at 07:50:01AM +0200, Christophe Leroy wrote: execute_location() and execute_user_location() intent to copy do_nothing() text and execute it at a new location. However, a

Re: [PATCH v2 12/13] lkdtm: Fix execute_[user]_location()

2021-10-15 Thread Christophe Leroy
Le 15/10/2021 à 23:31, Kees Cook a écrit : On Thu, Oct 14, 2021 at 07:50:01AM +0200, Christophe Leroy wrote: execute_location() and execute_user_location() intent to copy do_nothing() text and execute it at a new location. However, at the time being it doesn't copy do_nothing() function but d

Re: [PATCH v2 12/13] lkdtm: Fix execute_[user]_location()

2021-10-15 Thread Kees Cook
On Thu, Oct 14, 2021 at 07:50:01AM +0200, Christophe Leroy wrote: > execute_location() and execute_user_location() intent > to copy do_nothing() text and execute it at a new location. > However, at the time being it doesn't copy do_nothing() function > but do_nothing() function descriptor which sti

[PATCH v2 12/13] lkdtm: Fix execute_[user]_location()

2021-10-13 Thread Christophe Leroy
execute_location() and execute_user_location() intent to copy do_nothing() text and execute it at a new location. However, at the time being it doesn't copy do_nothing() function but do_nothing() function descriptor which still points to the original text. So at the end it still executes do_nothing