Re: [PATCH v2 2/2] ASoC: fsl-asoc-card: Add MQS support

2020-06-17 Thread Nicolin Chen
On Wed, Jun 17, 2020 at 12:48:25PM +0800, Shengjiu Wang wrote:
> The MQS codec isn't an i2c device, so use of_find_device_by_node
> to get platform device pointer.
> 
> Because MQS only support playback, then add a new audio map.
> 
> And there maybe "model" property or no "audio-routing" property in
> devicetree, so add some enhancement for these two property.
> 
> Signed-off-by: Shengjiu Wang 

Reviewed-by: Nicolin Chen 


[PATCH v2 2/2] ASoC: fsl-asoc-card: Add MQS support

2020-06-16 Thread Shengjiu Wang
The MQS codec isn't an i2c device, so use of_find_device_by_node
to get platform device pointer.

Because MQS only support playback, then add a new audio map.

And there maybe "model" property or no "audio-routing" property in
devicetree, so add some enhancement for these two property.

Signed-off-by: Shengjiu Wang 
---
changes in v2
- update according Nicolin's comments.

 sound/soc/fsl/fsl-asoc-card.c | 78 +--
 1 file changed, 57 insertions(+), 21 deletions(-)

diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index 00be73900888..d0543a53764e 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -119,6 +119,13 @@ static const struct snd_soc_dapm_route audio_map_ac97[] = {
{"ASRC-Capture",  NULL, "AC97 Capture"},
 };
 
+static const struct snd_soc_dapm_route audio_map_tx[] = {
+   /* 1st half -- Normal DAPM routes */
+   {"Playback",  NULL, "CPU-Playback"},
+   /* 2nd half -- ASRC DAPM routes */
+   {"CPU-Playback",  NULL, "ASRC-Playback"},
+};
+
 /* Add all possible widgets into here without being redundant */
 static const struct snd_soc_dapm_widget fsl_asoc_card_dapm_widgets[] = {
SND_SOC_DAPM_LINE("Line Out Jack", NULL),
@@ -485,8 +492,9 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
struct platform_device *asrc_pdev = NULL;
struct platform_device *cpu_pdev;
struct fsl_asoc_card_priv *priv;
-   struct i2c_client *codec_dev;
+   struct device *codec_dev = NULL;
const char *codec_dai_name;
+   const char *codec_dev_name;
u32 width;
int ret;
 
@@ -512,10 +520,23 @@ static int fsl_asoc_card_probe(struct platform_device 
*pdev)
}
 
codec_np = of_parse_phandle(np, "audio-codec", 0);
-   if (codec_np)
-   codec_dev = of_find_i2c_device_by_node(codec_np);
-   else
-   codec_dev = NULL;
+   if (codec_np) {
+   struct platform_device *codec_pdev;
+   struct i2c_client *codec_i2c;
+
+   codec_i2c = of_find_i2c_device_by_node(codec_np);
+   if (codec_i2c) {
+   codec_dev = _i2c->dev;
+   codec_dev_name = codec_i2c->name;
+   }
+   if (!codec_dev) {
+   codec_pdev = of_find_device_by_node(codec_np);
+   if (codec_pdev) {
+   codec_dev = _pdev->dev;
+   codec_dev_name = codec_pdev->name;
+   }
+   }
+   }
 
asrc_np = of_parse_phandle(np, "audio-asrc", 0);
if (asrc_np)
@@ -523,7 +544,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
 
/* Get the MCLK rate only, and leave it controlled by CODEC drivers */
if (codec_dev) {
-   struct clk *codec_clk = clk_get(_dev->dev, NULL);
+   struct clk *codec_clk = clk_get(codec_dev, NULL);
 
if (!IS_ERR(codec_clk)) {
priv->codec_priv.mclk_freq = clk_get_rate(codec_clk);
@@ -538,6 +559,11 @@ static int fsl_asoc_card_probe(struct platform_device 
*pdev)
/* Assign a default DAI format, and allow each card to overwrite it */
priv->dai_fmt = DAI_FMT_BASE;
 
+   memcpy(priv->dai_link, fsl_asoc_card_dai,
+  sizeof(struct snd_soc_dai_link) * ARRAY_SIZE(priv->dai_link));
+
+   priv->card.dapm_routes = audio_map;
+   priv->card.num_dapm_routes = ARRAY_SIZE(audio_map);
/* Diversify the card configurations */
if (of_device_is_compatible(np, "fsl,imx-audio-cs42888")) {
codec_dai_name = "cs42888";
@@ -573,6 +599,18 @@ static int fsl_asoc_card_probe(struct platform_device 
*pdev)
codec_dai_name = "ac97-hifi";
priv->card.set_bias_level = NULL;
priv->dai_fmt = SND_SOC_DAIFMT_AC97;
+   priv->card.dapm_routes = audio_map_ac97;
+   priv->card.num_dapm_routes = ARRAY_SIZE(audio_map_ac97);
+   } else if (of_device_is_compatible(np, "fsl,imx-audio-mqs")) {
+   codec_dai_name = "fsl-mqs-dai";
+   priv->card.set_bias_level = NULL;
+   priv->dai_fmt = SND_SOC_DAIFMT_LEFT_J |
+   SND_SOC_DAIFMT_CBS_CFS |
+   SND_SOC_DAIFMT_NB_NF;
+   priv->dai_link[1].dpcm_capture = 0;
+   priv->dai_link[2].dpcm_capture = 0;
+   priv->card.dapm_routes = audio_map_tx;
+   priv->card.num_dapm_routes = ARRAY_SIZE(audio_map_tx);
} else {
dev_err(>dev, "unknown Device Tree compatible\n");
ret = -EINVAL;
@@ -601,19 +639,17 @@ static int fsl_asoc_card_probe(struct platform_device 
*pdev)
priv->cpu_priv.sysclk_id[0] = FSL_SAI_CLK_MAST1;
}
 
-   snprintf(priv->name, sizeof(priv->name),