Re: [PATCH v2 2/2] hwmon: ibmpowernv: Add attributes to enable/disable sensor groups

2018-07-04 Thread Guenter Roeck
On 07/04/2018 09:53 AM, Shilpasri G Bhat wrote: Hi Guenter, Thanks for reviewing the patch. On 07/04/2018 08:16 PM, Guenter Roeck wrote: +/* Disable if last sensor in the group */ +send_command = true; +for (i = 0; i < sg->nr_sensor; i++) { +struct

Re: [PATCH v2 2/2] hwmon: ibmpowernv: Add attributes to enable/disable sensor groups

2018-07-04 Thread Shilpasri G Bhat
Hi Guenter, Thanks for reviewing the patch. On 07/04/2018 08:16 PM, Guenter Roeck wrote: >> +/* Disable if last sensor in the group */ >> +send_command = true; >> +for (i = 0; i < sg->nr_sensor; i++) { >> +struct sensor_data *sd = sg->sensors[i]; >> + >> +

Re: [PATCH v2 2/2] hwmon: ibmpowernv: Add attributes to enable/disable sensor groups

2018-07-04 Thread Guenter Roeck
On 07/04/2018 02:16 AM, Shilpasri G Bhat wrote: On-Chip-Controller(OCC) is an embedded micro-processor in POWER9 chip which measures various system and chip level sensors. These sensors comprises of environmental sensors (like power, temperature, current and voltage) and performance sensors

[PATCH v2 2/2] hwmon: ibmpowernv: Add attributes to enable/disable sensor groups

2018-07-04 Thread Shilpasri G Bhat
On-Chip-Controller(OCC) is an embedded micro-processor in POWER9 chip which measures various system and chip level sensors. These sensors comprises of environmental sensors (like power, temperature, current and voltage) and performance sensors (like utilization, frequency). All these sensors are