Re: [PATCH v2 6/7] mm/treewide: Replace pud_large() with pud_leaf()

2024-03-04 Thread Jason Gunthorpe
On Thu, Feb 29, 2024 at 04:42:57PM +0800, pet...@redhat.com wrote:
> From: Peter Xu 
> 
> pud_large() is always defined as pud_leaf().  Merge their usages.  Chose
> pud_leaf() because pud_leaf() is a global API, while pud_large() is not.
> 
> Signed-off-by: Peter Xu 
> ---
>  arch/powerpc/mm/book3s64/pgtable.c | 2 +-
>  arch/s390/boot/vmem.c  | 2 +-
>  arch/s390/include/asm/pgtable.h| 4 ++--
>  arch/s390/mm/gmap.c| 2 +-
>  arch/s390/mm/hugetlbpage.c | 4 ++--
>  arch/s390/mm/pageattr.c| 2 +-
>  arch/s390/mm/pgtable.c | 2 +-
>  arch/s390/mm/vmem.c| 6 +++---
>  arch/sparc/mm/init_64.c| 2 +-
>  arch/x86/kvm/mmu/mmu.c | 2 +-
>  arch/x86/mm/fault.c| 4 ++--
>  arch/x86/mm/ident_map.c| 2 +-
>  arch/x86/mm/init_64.c  | 4 ++--
>  arch/x86/mm/kasan_init_64.c| 2 +-
>  arch/x86/mm/mem_encrypt_identity.c | 2 +-
>  arch/x86/mm/pat/set_memory.c   | 6 +++---
>  arch/x86/mm/pgtable.c  | 2 +-
>  arch/x86/mm/pti.c  | 2 +-
>  arch/x86/power/hibernate.c | 2 +-
>  arch/x86/xen/mmu_pv.c  | 4 ++--
>  20 files changed, 29 insertions(+), 29 deletions(-)

Reviewed-by: Jason Gunthorpe 

Jason


[PATCH v2 6/7] mm/treewide: Replace pud_large() with pud_leaf()

2024-02-29 Thread peterx
From: Peter Xu 

pud_large() is always defined as pud_leaf().  Merge their usages.  Chose
pud_leaf() because pud_leaf() is a global API, while pud_large() is not.

Signed-off-by: Peter Xu 
---
 arch/powerpc/mm/book3s64/pgtable.c | 2 +-
 arch/s390/boot/vmem.c  | 2 +-
 arch/s390/include/asm/pgtable.h| 4 ++--
 arch/s390/mm/gmap.c| 2 +-
 arch/s390/mm/hugetlbpage.c | 4 ++--
 arch/s390/mm/pageattr.c| 2 +-
 arch/s390/mm/pgtable.c | 2 +-
 arch/s390/mm/vmem.c| 6 +++---
 arch/sparc/mm/init_64.c| 2 +-
 arch/x86/kvm/mmu/mmu.c | 2 +-
 arch/x86/mm/fault.c| 4 ++--
 arch/x86/mm/ident_map.c| 2 +-
 arch/x86/mm/init_64.c  | 4 ++--
 arch/x86/mm/kasan_init_64.c| 2 +-
 arch/x86/mm/mem_encrypt_identity.c | 2 +-
 arch/x86/mm/pat/set_memory.c   | 6 +++---
 arch/x86/mm/pgtable.c  | 2 +-
 arch/x86/mm/pti.c  | 2 +-
 arch/x86/power/hibernate.c | 2 +-
 arch/x86/xen/mmu_pv.c  | 4 ++--
 20 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/arch/powerpc/mm/book3s64/pgtable.c 
b/arch/powerpc/mm/book3s64/pgtable.c
index 45f526547b27..83823db3488b 100644
--- a/arch/powerpc/mm/book3s64/pgtable.c
+++ b/arch/powerpc/mm/book3s64/pgtable.c
@@ -130,7 +130,7 @@ void set_pud_at(struct mm_struct *mm, unsigned long addr,
 
WARN_ON(pte_hw_valid(pud_pte(*pudp)));
assert_spin_locked(pud_lockptr(mm, pudp));
-   WARN_ON(!(pud_large(pud)));
+   WARN_ON(!(pud_leaf(pud)));
 #endif
trace_hugepage_set_pud(addr, pud_val(pud));
return set_pte_at(mm, addr, pudp_ptep(pudp), pud_pte(pud));
diff --git a/arch/s390/boot/vmem.c b/arch/s390/boot/vmem.c
index 348ab02b1028..09b10bb6e4d0 100644
--- a/arch/s390/boot/vmem.c
+++ b/arch/s390/boot/vmem.c
@@ -366,7 +366,7 @@ static void pgtable_pud_populate(p4d_t *p4d, unsigned long 
addr, unsigned long e
}
pmd = boot_crst_alloc(_SEGMENT_ENTRY_EMPTY);
pud_populate(_mm, pud, pmd);
-   } else if (pud_large(*pud)) {
+   } else if (pud_leaf(*pud)) {
continue;
}
pgtable_pmd_populate(pud, addr, next, mode);
diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
index 431d03d5116b..a5f16a244a64 100644
--- a/arch/s390/include/asm/pgtable.h
+++ b/arch/s390/include/asm/pgtable.h
@@ -730,7 +730,7 @@ static inline int pud_bad(pud_t pud)
 {
unsigned long type = pud_val(pud) & _REGION_ENTRY_TYPE_MASK;
 
-   if (type > _REGION_ENTRY_TYPE_R3 || pud_large(pud))
+   if (type > _REGION_ENTRY_TYPE_R3 || pud_leaf(pud))
return 1;
if (type < _REGION_ENTRY_TYPE_R3)
return 0;
@@ -1400,7 +1400,7 @@ static inline unsigned long pud_deref(pud_t pud)
unsigned long origin_mask;
 
origin_mask = _REGION_ENTRY_ORIGIN;
-   if (pud_large(pud))
+   if (pud_leaf(pud))
origin_mask = _REGION3_ENTRY_ORIGIN_LARGE;
return (unsigned long)__va(pud_val(pud) & origin_mask);
 }
diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c
index a4f34c1db3cf..dcb38e351fa6 100644
--- a/arch/s390/mm/gmap.c
+++ b/arch/s390/mm/gmap.c
@@ -596,7 +596,7 @@ int __gmap_link(struct gmap *gmap, unsigned long gaddr, 
unsigned long vmaddr)
pud = pud_offset(p4d, vmaddr);
VM_BUG_ON(pud_none(*pud));
/* large puds cannot yet be handled */
-   if (pud_large(*pud))
+   if (pud_leaf(*pud))
return -EFAULT;
pmd = pmd_offset(pud, vmaddr);
VM_BUG_ON(pmd_none(*pmd));
diff --git a/arch/s390/mm/hugetlbpage.c b/arch/s390/mm/hugetlbpage.c
index 1ccb5b40fe92..c2e8242bd15d 100644
--- a/arch/s390/mm/hugetlbpage.c
+++ b/arch/s390/mm/hugetlbpage.c
@@ -224,7 +224,7 @@ pte_t *huge_pte_offset(struct mm_struct *mm,
if (p4d_present(*p4dp)) {
pudp = pud_offset(p4dp, addr);
if (pud_present(*pudp)) {
-   if (pud_large(*pudp))
+   if (pud_leaf(*pudp))
return (pte_t *) pudp;
pmdp = pmd_offset(pudp, addr);
}
@@ -240,7 +240,7 @@ int pmd_huge(pmd_t pmd)
 
 int pud_huge(pud_t pud)
 {
-   return pud_large(pud);
+   return pud_leaf(pud);
 }
 
 bool __init arch_hugetlb_valid_size(unsigned long size)
diff --git a/arch/s390/mm/pageattr.c b/arch/s390/mm/pageattr.c
index 9f55d5a3210c..01bc8fad64d6 100644
--- a/arch/s390/mm/pageattr.c
+++ b/arch/s390/mm/pageattr.c
@@ -274,7 +274,7 @@ static int walk_pud_level(p4d_t *p4d, unsigned long addr, 
unsigned long end,
if (pud_none(*pudp))
return -EINVAL;
next = pud_addr_end(addr, end);
-   if (pud_large(*pudp)) {
+