Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2018-12-28 Thread wen.yang99
-dev@lists.ozlabs.org Date: 2018/12/29 13:11 Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm From: Peng Hao Date: Wed, 26 Dec 2018 16:26:29 +0800 > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c > index 839fa77..8ce4921f

Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2018-12-28 Thread David Miller
From: Peng Hao Date: Wed, 26 Dec 2018 16:26:29 +0800 > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c > index 839fa77..8ce4921f 100644 > --- a/drivers/net/wan/fsl_ucc_hdlc.c > +++ b/drivers/net/wan/fsl_ucc_hdlc.c > @@ -1057,6 +1057,27 @@ static const struct

[PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2018-12-26 Thread Peng Hao
From: Wen Yang Currently there are some issues with the ucc_of_parse_tdm function: 1, a possible null pointer dereference in ucc_of_parse_tdm, detected by the semantic patch deref_null.cocci, with the following warning: drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced.