Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()

2020-01-14 Thread Mark Brown
On Tue, Jan 14, 2020 at 04:26:18PM +, Joakim Tjernlund wrote: > Don't you need to "undo" ioremap, irq etc. in case of later errors? Better, convert to devm_ signature.asc Description: PGP signature

Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()

2020-01-14 Thread Joakim Tjernlund
On Tue, 2020-01-14 at 16:02 +, Christophe Leroy wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > No need to 'goto err;' for just doing a return. > return

[PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()

2020-01-14 Thread Christophe Leroy
No need to 'goto err;' for just doing a return. return directly from where the error happens. Signed-off-by: Christophe Leroy --- v3: rebase on today's spi/for-next and using PTR_ERR_OR_ZERO() in one place. --- drivers/spi/spi-fsl-spi.c | 27 --- 1 file changed, 8