Re: [PATCH v3 08/12] asm-generic: Refactor dereference_[kernel]_function_descriptor()

2022-02-14 Thread Christophe Leroy
Le 11/02/2022 à 01:56, Kees Cook a écrit : > On Thu, Feb 10, 2022 at 09:30:43PM +1100, Michael Ellerman wrote: >> Christophe Leroy writes: >>> diff --git a/kernel/extable.c b/kernel/extable.c >>> index b0ea5eb0c3b4..1ef13789bea9 100644 >>> --- a/kernel/extable.c >>> +++ b/kernel/extable.c >>> @@

Re: [PATCH v3 08/12] asm-generic: Refactor dereference_[kernel]_function_descriptor()

2022-02-10 Thread Kees Cook
On Thu, Feb 10, 2022 at 09:30:43PM +1100, Michael Ellerman wrote: > Christophe Leroy writes: > > diff --git a/kernel/extable.c b/kernel/extable.c > > index b0ea5eb0c3b4..1ef13789bea9 100644 > > --- a/kernel/extable.c > > +++ b/kernel/extable.c > > @@ -159,12 +160,32 @@ int kernel_text_address(unsi

Re: [PATCH v3 08/12] asm-generic: Refactor dereference_[kernel]_function_descriptor()

2022-02-10 Thread Michael Ellerman
Christophe Leroy writes: > diff --git a/kernel/extable.c b/kernel/extable.c > index b0ea5eb0c3b4..1ef13789bea9 100644 > --- a/kernel/extable.c > +++ b/kernel/extable.c > @@ -159,12 +160,32 @@ int kernel_text_address(unsigned long addr) > } > > /* > - * On some architectures (PPC64, IA64) funct

[PATCH v3 08/12] asm-generic: Refactor dereference_[kernel]_function_descriptor()

2021-10-17 Thread Christophe Leroy
dereference_function_descriptor() and dereference_kernel_function_descriptor() are identical on the three architectures implementing them. Make them common and put them out-of-line in kernel/extable.c which is one of the users and has similar type of functions. Reviewed-by: Kees Cook Reviewed-by