Re: [PATCH v3 3/3] powerpc/process: Constify the number of insns printed by show instructions functions.

[Murilo Opsfelder Araujo]

On Fri, Sep 07, 2018 at 01:47:33PM +, Christophe Leroy wrote:
> instructions_to_print var is assigned value 16 and there is no
> way to change it.
> 
> This patch replaces it by a constant.
> 
> Signed-off-by: Christophe Leroy 

Reviewed-by: Murilo Opsfelder Araujo 

> ---
>  v3: no change
>  v2: no change
> 
>  arch/powerpc/kernel/process.c | 11 +--
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 2a39f7aca846..7d86b4f7949e 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -1261,17 +1261,16 @@ struct task_struct *__switch_to(struct task_struct 
> *prev,
>   return last;
>  }
>  
> -static int instructions_to_print = 16;
> +#define NR_INSN_TO_PRINT 16
>  
>  static void show_instructions(struct pt_regs *regs)
>  {
>   int i;
> - unsigned long pc = regs->nip - (instructions_to_print * 3 / 4 *
> - sizeof(int));
> + unsigned long pc = regs->nip - (NR_INSN_TO_PRINT * 3 / 4 * sizeof(int));
>  
>   printk("Instruction dump:");
>  
> - for (i = 0; i < instructions_to_print; i++) {
> + for (i = 0; i < NR_INSN_TO_PRINT; i++) {
>   int instr;
>  
>   if (!(i % 8))
> @@ -1304,11 +1303,11 @@ static void show_instructions(struct pt_regs *regs)
>  void show_user_instructions(struct pt_regs *regs)
>  {
>   unsigned long pc;
> - int n = instructions_to_print;
> + int n = NR_INSN_TO_PRINT;
>   struct seq_buf s;
>   char buf[96]; /* enough for 8 times 9 + 2 chars */
>  
> - pc = regs->nip - (instructions_to_print * 3 / 4 * sizeof(int));
> + pc = regs->nip - (NR_INSN_TO_PRINT * 3 / 4 * sizeof(int));
>  
>   seq_buf_init(, buf, sizeof(buf));
>  
> -- 
> 2.13.3
> 

-- 
Murilo

[PATCH v3 3/3] powerpc/process: Constify the number of insns printed by show instructions functions.

[Christophe Leroy]

instructions_to_print var is assigned value 16 and there is no
way to change it.

This patch replaces it by a constant.

Signed-off-by: Christophe Leroy 
---
 v3: no change
 v2: no change

 arch/powerpc/kernel/process.c | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 2a39f7aca846..7d86b4f7949e 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -1261,17 +1261,16 @@ struct task_struct *__switch_to(struct task_struct 
*prev,
return last;
 }
 
-static int instructions_to_print = 16;
+#define NR_INSN_TO_PRINT   16
 
 static void show_instructions(struct pt_regs *regs)
 {
int i;
-   unsigned long pc = regs->nip - (instructions_to_print * 3 / 4 *
-   sizeof(int));
+   unsigned long pc = regs->nip - (NR_INSN_TO_PRINT * 3 / 4 * sizeof(int));
 
printk("Instruction dump:");
 
-   for (i = 0; i < instructions_to_print; i++) {
+   for (i = 0; i < NR_INSN_TO_PRINT; i++) {
int instr;
 
if (!(i % 8))
@@ -1304,11 +1303,11 @@ static void show_instructions(struct pt_regs *regs)
 void show_user_instructions(struct pt_regs *regs)
 {
unsigned long pc;
-   int n = instructions_to_print;
+   int n = NR_INSN_TO_PRINT;
struct seq_buf s;
char buf[96]; /* enough for 8 times 9 + 2 chars */
 
-   pc = regs->nip - (instructions_to_print * 3 / 4 * sizeof(int));
+   pc = regs->nip - (NR_INSN_TO_PRINT * 3 / 4 * sizeof(int));
 
seq_buf_init(, buf, sizeof(buf));
 
-- 
2.13.3