Re: [PATCH v4] powernv/sensor: Handle OPAL_WRONG_STATE error return

[Vipin K Parashar]

Hi Michael,

Any feedback/outlook with this patch ?

Regards,
Vipin


On Friday 10 March 2017 05:27 PM, Vipin K Parashar wrote:

OPAL returns OPAL_WRONG_STATE upon failing to provide
sensor data due to core sleeping/offline. Added check
in opal_get_sensor_data() for sensor read failure with
OPAL_WRONG_STATE return code and returned -EIO.

Signed-off-by: Vipin K Parashar 
---
Changes in v4:
  - Removed sleeping core log message with KERN_NOTICE priority.

Changes in v3:
  - Added a new case for OPAL_WRONG_STATE in sensor read
along with a log message indicating sleeping/offline core
causing read fail.

  arch/powerpc/platforms/powernv/opal-sensor.c | 4 
  1 file changed, 4 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/opal-sensor.c 
b/arch/powerpc/platforms/powernv/opal-sensor.c
index 308efd1..aa267f1 100644
--- a/arch/powerpc/platforms/powernv/opal-sensor.c
+++ b/arch/powerpc/platforms/powernv/opal-sensor.c
@@ -64,6 +64,10 @@ int opal_get_sensor_data(u32 sensor_hndl, u32 *sensor_data)
*sensor_data = be32_to_cpu(data);
break;

+   case OPAL_WRONG_STATE:
+   ret = -EIO;
+   break;
+
default:
ret = opal_error_code(ret);
break;

[PATCH v4] powernv/sensor: Handle OPAL_WRONG_STATE error return

[Vipin K Parashar]

OPAL returns OPAL_WRONG_STATE upon failing to provide
sensor data due to core sleeping/offline. Added check
in opal_get_sensor_data() for sensor read failure with
OPAL_WRONG_STATE return code and returned -EIO.

Signed-off-by: Vipin K Parashar 
---
Changes in v4:
 - Removed sleeping core log message with KERN_NOTICE priority.

Changes in v3:
 - Added a new case for OPAL_WRONG_STATE in sensor read
   along with a log message indicating sleeping/offline core
   causing read fail.

 arch/powerpc/platforms/powernv/opal-sensor.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/opal-sensor.c 
b/arch/powerpc/platforms/powernv/opal-sensor.c
index 308efd1..aa267f1 100644
--- a/arch/powerpc/platforms/powernv/opal-sensor.c
+++ b/arch/powerpc/platforms/powernv/opal-sensor.c
@@ -64,6 +64,10 @@ int opal_get_sensor_data(u32 sensor_hndl, u32 *sensor_data)
*sensor_data = be32_to_cpu(data);
break;
 
+   case OPAL_WRONG_STATE:
+   ret = -EIO;
+   break;
+
default:
ret = opal_error_code(ret);
break;
-- 
2.7.4