Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/22/2013 07:48 PM, Jason Cooper wrote: On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: On 05/22/2013 07:35 PM, Jason Cooper wrote: On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: Just tested on Dockstar with gated clocks and modular DT mv643xx

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 08:55:01PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 08:49 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 07:48 PM, Jason Cooper wrote: > >>>On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hes

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/22/2013 08:49 PM, Jason Cooper wrote: On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: On 05/22/2013 07:48 PM, Jason Cooper wrote: On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: Hmm, maybe a little bit too early. While restoring the MAC addre

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/22/2013 08:24 PM, Jason Gunthorpe wrote: On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: Not neccessary anyway, after talking Jason C in a Kirkwood-only workaround I prepared a patch that reads mac address registers early and stores it in the local-mac-address proper

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 07:48 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > >>Hmm, maybe a little bit too early. While restoring the MAC address now > >>works, another bug arises whi

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/22/2013 07:48 PM, Jason Cooper wrote: On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: Hmm, maybe a little bit too early. While restoring the MAC address now works, another bug arises which I guess is related with phy setup and aneg. Will investigate and update patch

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Gunthorpe
On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > Not neccessary anyway, after talking Jason C in a Kirkwood-only > workaround I prepared a patch that reads mac address registers early > and stores it in the local-mac-address property. That sounds great, but, FWIW, our boo

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 07:35 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: > >>>On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Coop

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/22/2013 07:35 PM, Jason Cooper wrote: On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: iirc, our solution to this was to parse the ATAGs for the mac addr and

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: > >On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > >>iirc, our solution to this was to parse the ATAGs for the mac addr and > >>update the appended dtb. This way,

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: iirc, our solution to this was to parse the ATAGs for the mac addr and update the appended dtb. This way, module load and unload would work without loosing the mac address. I believe Ja

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Gunthorpe
On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > iirc, our solution to this was to parse the ATAGs for the mac addr and > update the appended dtb. This way, module load and unload would work > without loosing the mac address. I believe Jason Gunthorpe has a patch > to atags_to_fdt

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 10:59:08AM -0600, Jason Gunthorpe wrote: > On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > > > iirc, our solution to this was to parse the ATAGs for the mac addr and > > update the appended dtb. This way, module load and unload would work > > without loosin

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 12:13:58PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 12:04 PM, tiejun.chen wrote: > >On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: > >>On 05/21/2013 07:48 PM, Andrew Lunn wrote: > >>>On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: > >>

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/22/2013 12:04 PM, tiejun.chen wrote: On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: On 05/21/2013 07:48 PM, Andrew Lunn wrote: On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: This patch adds orion-eth and mvmdio device tree nodes for DT enabled Dove boards. A

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread tiejun.chen
On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: On 05/21/2013 07:48 PM, Andrew Lunn wrote: On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: This patch adds orion-eth and mvmdio device tree nodes for DT enabled Dove boards. As there is only one ethernet controller on D

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Sebastian Hesselbarth
On 05/21/2013 07:48 PM, Andrew Lunn wrote: On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: This patch adds orion-eth and mvmdio device tree nodes for DT enabled Dove boards. As there is only one ethernet controller on Dove, a default phy node is also added with a note to s

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-21 Thread Andrew Lunn
On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: > This patch adds orion-eth and mvmdio device tree nodes for DT enabled > Dove boards. As there is only one ethernet controller on Dove, a default > phy node is also added with a note to set its reg property on a per-board > bas

[PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-21 Thread Sebastian Hesselbarth
This patch adds orion-eth and mvmdio device tree nodes for DT enabled Dove boards. As there is only one ethernet controller on Dove, a default phy node is also added with a note to set its reg property on a per-board basis. Signed-off-by: Sebastian Hesselbarth --- Changelog: v3->v4: - convert to