Re: [PATCH v5 14/31] powernv/fadump: define register/un-register callback functions

2019-09-05 Thread Hari Bathini



On 05/09/19 12:53 PM, Michael Ellerman wrote:
> Hari Bathini  writes:
>> diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c 
>> b/arch/powerpc/platforms/powernv/opal-fadump.c
>> index e466f7e..91fb909 100644
>> --- a/arch/powerpc/platforms/powernv/opal-fadump.c
>> +++ b/arch/powerpc/platforms/powernv/opal-fadump.c
>> @@ -52,6 +68,8 @@ static ulong opal_fadump_init_mem_struct(struct fw_dump 
>> *fadump_conf)
>>  opal_fdm->fadumphdr_addr = (opal_fdm->rgn[0].dest +
>>  fadump_conf->boot_memory_size);
>>  
>> +opal_fadump_update_config(fadump_conf, opal_fdm);
>> +
>>  return addr;
>>  }
>>  
>> @@ -97,12 +115,69 @@ static int opal_fadump_setup_metadata(struct fw_dump 
>> *fadump_conf)
>>  
>>  static int opal_fadump_register(struct fw_dump *fadump_conf)
>>  {
>> -return -EIO;
>> +int i, err = -EIO;
>> +s64 rc;
> 
> Some compiler versions are warning about this being used uninitialised:
> 
> arch/powerpc/platforms/powernv/opal-fadump.c:316:3: error: 'rc' may be used 
> uninitialized in this function [-Werror=uninitialized]
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/13943984/
> 
> Which does seem like a legitimate warning.

fixed...



Re: [PATCH v5 14/31] powernv/fadump: define register/un-register callback functions

2019-09-05 Thread Michael Ellerman
Hari Bathini  writes:
> diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c 
> b/arch/powerpc/platforms/powernv/opal-fadump.c
> index e466f7e..91fb909 100644
> --- a/arch/powerpc/platforms/powernv/opal-fadump.c
> +++ b/arch/powerpc/platforms/powernv/opal-fadump.c
> @@ -52,6 +68,8 @@ static ulong opal_fadump_init_mem_struct(struct fw_dump 
> *fadump_conf)
>   opal_fdm->fadumphdr_addr = (opal_fdm->rgn[0].dest +
>   fadump_conf->boot_memory_size);
>  
> + opal_fadump_update_config(fadump_conf, opal_fdm);
> +
>   return addr;
>  }
>  
> @@ -97,12 +115,69 @@ static int opal_fadump_setup_metadata(struct fw_dump 
> *fadump_conf)
>  
>  static int opal_fadump_register(struct fw_dump *fadump_conf)
>  {
> - return -EIO;
> + int i, err = -EIO;
> + s64 rc;

Some compiler versions are warning about this being used uninitialised:

arch/powerpc/platforms/powernv/opal-fadump.c:316:3: error: 'rc' may be used 
uninitialized in this function [-Werror=uninitialized]

http://kisskb.ellerman.id.au/kisskb/buildresult/13943984/

Which does seem like a legitimate warning.

cheers


Re: [PATCH v5 14/31] powernv/fadump: define register/un-register callback functions

2019-09-04 Thread Michael Ellerman
Hari Bathini  writes:
> Make OPAL calls to register and un-register with firmware for MPIPL.
>

This has the same subject as patch 6, would be good to make them
different.

cheers


[PATCH v5 14/31] powernv/fadump: define register/un-register callback functions

2019-08-20 Thread Hari Bathini
Make OPAL calls to register and un-register with firmware for MPIPL.

Signed-off-by: Hari Bathini 
---
 arch/powerpc/platforms/powernv/opal-fadump.c |   79 +-
 1 file changed, 77 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c 
b/arch/powerpc/platforms/powernv/opal-fadump.c
index e466f7e..91fb909 100644
--- a/arch/powerpc/platforms/powernv/opal-fadump.c
+++ b/arch/powerpc/platforms/powernv/opal-fadump.c
@@ -23,6 +23,22 @@
 
 static struct opal_fadump_mem_struct *opal_fdm;
 
+static int opal_fadump_unregister(struct fw_dump *fadump_conf);
+
+static void opal_fadump_update_config(struct fw_dump *fadump_conf,
+ const struct opal_fadump_mem_struct *fdm)
+{
+   /*
+* The destination address of the first boot memory region is the
+* destination address of boot memory regions.
+*/
+   fadump_conf->boot_mem_dest_addr = fdm->rgn[0].dest;
+   pr_debug("Destination address of boot memory regions: %#016lx\n",
+fadump_conf->boot_mem_dest_addr);
+
+   fadump_conf->fadumphdr_addr = fdm->fadumphdr_addr;
+}
+
 /* Initialize kernel metadata */
 static void opal_fadump_init_metadata(struct opal_fadump_mem_struct *fdm)
 {
@@ -52,6 +68,8 @@ static ulong opal_fadump_init_mem_struct(struct fw_dump 
*fadump_conf)
opal_fdm->fadumphdr_addr = (opal_fdm->rgn[0].dest +
fadump_conf->boot_memory_size);
 
+   opal_fadump_update_config(fadump_conf, opal_fdm);
+
return addr;
 }
 
@@ -97,12 +115,69 @@ static int opal_fadump_setup_metadata(struct fw_dump 
*fadump_conf)
 
 static int opal_fadump_register(struct fw_dump *fadump_conf)
 {
-   return -EIO;
+   int i, err = -EIO;
+   s64 rc;
+
+   for (i = 0; i < opal_fdm->region_cnt; i++) {
+   rc = opal_mpipl_update(OPAL_MPIPL_ADD_RANGE,
+  opal_fdm->rgn[i].src,
+  opal_fdm->rgn[i].dest,
+  opal_fdm->rgn[i].size);
+   if (rc != OPAL_SUCCESS)
+   break;
+
+   opal_fdm->registered_regions++;
+   }
+
+   switch (rc) {
+   case OPAL_SUCCESS:
+   pr_info("Registration is successful!\n");
+   fadump_conf->dump_registered = 1;
+   err = 0;
+   break;
+   case OPAL_RESOURCE:
+   /* If MAX regions limit in f/w is hit, warn and proceed. */
+   pr_warn("%d regions could not be registered for MPIPL as MAX 
limit is reached!\n",
+   (opal_fdm->region_cnt - opal_fdm->registered_regions));
+   fadump_conf->dump_registered = 1;
+   err = 0;
+   break;
+   case OPAL_PARAMETER:
+   pr_err("Failed to register. Parameter Error(%lld).\n", rc);
+   break;
+   case OPAL_HARDWARE:
+   pr_err("Support not available.\n");
+   fadump_conf->fadump_supported = 0;
+   fadump_conf->fadump_enabled = 0;
+   break;
+   default:
+   pr_err("Failed to register. Unknown Error(%lld).\n", rc);
+   break;
+   }
+
+   /*
+* If some regions were registered before OPAL_MPIPL_ADD_RANGE
+* OPAL call failed, unregister all regions.
+*/
+   if ((err < 0) && (opal_fdm->registered_regions > 0))
+   opal_fadump_unregister(fadump_conf);
+
+   return err;
 }
 
 static int opal_fadump_unregister(struct fw_dump *fadump_conf)
 {
-   return -EIO;
+   s64 rc;
+
+   rc = opal_mpipl_update(OPAL_MPIPL_REMOVE_ALL, 0, 0, 0);
+   if (rc) {
+   pr_err("Failed to un-register - unexpected Error(%lld).\n", rc);
+   return -EIO;
+   }
+
+   opal_fdm->registered_regions = 0;
+   fadump_conf->dump_registered = 0;
+   return 0;
 }
 
 static int opal_fadump_invalidate(struct fw_dump *fadump_conf)