Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-15 Thread Balamuruhan S
On Wed, 2020-04-15 at 14:40 +1000, Jordan Niethe wrote: > On Mon, Apr 13, 2020 at 10:04 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > > For powerpc64, redefine the ppc_inst type so both word and prefixed > > > instructions can be represented. On powerpc32

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-14 Thread Jordan Niethe
On Mon, Apr 13, 2020 at 10:04 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > For powerpc64, redefine the ppc_inst type so both word and prefixed > > instructions can be represented. On powerpc32 the type will remain the > > same. Update places which had as

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-13 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > For powerpc64, redefine the ppc_inst type so both word and prefixed > instructions can be represented. On powerpc32 the type will remain the > same. Update places which had assumed instructions to be 4 bytes long. > > Signed-off-by: Jordan

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-08 Thread Christophe Leroy
Le 08/04/2020 à 20:11, Segher Boessenkool a écrit : On Mon, Apr 06, 2020 at 12:25:27PM +0200, Christophe Leroy wrote: if (ppc_inst_prefixed(x) != ppc_inst_prefixed(y)) return false; else if (ppc_inst_prefixed(x)) return !memcmp(&x, &y, sizeof(st

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-08 Thread Segher Boessenkool
On Mon, Apr 06, 2020 at 12:25:27PM +0200, Christophe Leroy wrote: > > if (ppc_inst_prefixed(x) != ppc_inst_prefixed(y)) > > return false; > > else if (ppc_inst_prefixed(x)) > > return !memcmp(&x, &y, sizeof(struct ppc_inst)); > > Are we sure memcmp() is a good candi

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-06 Thread Alistair Popple
On Monday, 6 April 2020 8:42:57 PM AEST Jordan Niethe wrote: > On Mon, 6 Apr 2020, 7:52 pm Alistair Popple, wrote: > > > diff --git a/arch/powerpc/include/asm/inst.h > > > b/arch/powerpc/include/asm/inst.h index 70b37a35a91a..7e23e7146c66 > > > 100644 > > > --- a/arch/powerpc/include/asm/inst.h >

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-06 Thread Jordan Niethe
On Mon, Apr 6, 2020 at 8:25 PM Christophe Leroy wrote: > > > > Le 06/04/2020 à 11:52, Alistair Popple a écrit : > > [...] > > >> @@ -32,14 +76,31 @@ static inline struct ppc_inst ppc_inst_swab(struct > >> ppc_inst x) return ppc_inst(swab32(ppc_inst_val(x))); > >> } > >> > >> +static inline u32 p

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-06 Thread kbuild test robot
Hi Jordan, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.6] [cannot apply to powerpc/next kvm-ppc/kvm-ppc-next scottwood/next next-20200406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-06 Thread Jordan Niethe
On Mon, 6 Apr 2020, 7:52 pm Alistair Popple, wrote: > > diff --git a/arch/powerpc/include/asm/inst.h > > b/arch/powerpc/include/asm/inst.h index 70b37a35a91a..7e23e7146c66 100644 > > --- a/arch/powerpc/include/asm/inst.h > > +++ b/arch/powerpc/include/asm/inst.h > > @@ -8,23 +8,67 @@ > > > > str

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-06 Thread Christophe Leroy
Le 06/04/2020 à 11:52, Alistair Popple a écrit : [...] @@ -32,14 +76,31 @@ static inline struct ppc_inst ppc_inst_swab(struct ppc_inst x) return ppc_inst(swab32(ppc_inst_val(x))); } +static inline u32 ppc_inst_val(struct ppc_inst x) +{ + return x.val; +} + static inline struct ppc

Re: [PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-06 Thread Alistair Popple
> diff --git a/arch/powerpc/include/asm/inst.h > b/arch/powerpc/include/asm/inst.h index 70b37a35a91a..7e23e7146c66 100644 > --- a/arch/powerpc/include/asm/inst.h > +++ b/arch/powerpc/include/asm/inst.h > @@ -8,23 +8,67 @@ > > struct ppc_inst { > u32 val; > +#ifdef __powerpc64__ > +

[PATCH v5 18/21] powerpc64: Add prefixed instructions to instruction data type

2020-04-06 Thread Jordan Niethe
For powerpc64, redefine the ppc_inst type so both word and prefixed instructions can be represented. On powerpc32 the type will remain the same. Update places which had assumed instructions to be 4 bytes long. Signed-off-by: Jordan Niethe --- v4: New to series v5: - Distinguish normal instructi