Re: [PATCH v5 3/4] mm/nvdimm: Use correct #defines instead of open coding

2019-08-19 Thread Dan Williams
On Mon, Aug 19, 2019 at 2:32 AM Aneesh Kumar K.V wrote: > > Aneesh Kumar K.V writes: > > > Dan Williams writes: > > > >> On Fri, Aug 9, 2019 at 12:45 AM Aneesh Kumar K.V > >> wrote: > >>> > >> > > ... > > >>> diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c > >>> index

Re: [PATCH v5 3/4] mm/nvdimm: Use correct #defines instead of open coding

2019-08-19 Thread Aneesh Kumar K.V
Aneesh Kumar K.V writes: > Dan Williams writes: > >> On Fri, Aug 9, 2019 at 12:45 AM Aneesh Kumar K.V >> wrote: >>> >> ... >>> diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c >>> index 37e96811c2fc..c1d9be609322 100644 >>> --- a/drivers/nvdimm/pfn_devs.c >>> +++

Re: [PATCH v5 3/4] mm/nvdimm: Use correct #defines instead of open coding

2019-08-19 Thread Aneesh Kumar K.V
Dan Williams writes: > On Fri, Aug 9, 2019 at 12:45 AM Aneesh Kumar K.V > wrote: >> >> Use PAGE_SIZE instead of SZ_4K and sizeof(struct page) instead of 64. >> If we have a kernel built with different struct page size the previous >> patch should handle marking the namespace disabled. > > Each

Re: [PATCH v5 3/4] mm/nvdimm: Use correct #defines instead of open coding

2019-08-15 Thread Dan Williams
On Fri, Aug 9, 2019 at 12:45 AM Aneesh Kumar K.V wrote: > > Use PAGE_SIZE instead of SZ_4K and sizeof(struct page) instead of 64. > If we have a kernel built with different struct page size the previous > patch should handle marking the namespace disabled. Each of these changes carry independent

[PATCH v5 3/4] mm/nvdimm: Use correct #defines instead of open coding

2019-08-09 Thread Aneesh Kumar K.V
Use PAGE_SIZE instead of SZ_4K and sizeof(struct page) instead of 64. If we have a kernel built with different struct page size the previous patch should handle marking the namespace disabled. Signed-off-by: Aneesh Kumar K.V --- drivers/nvdimm/label.c | 2 +-