On 08/19/2015 05:24 PM, Jacek Anaszewski wrote:
Hi Vasant,
On 07/28/2015 07:40 PM, Jacek Anaszewski wrote:
Vasant,
Without my core changes your driver won't work with led triggers, but
AFAIR this use case is not relevant for your LEDs? Eventually, we could
produce a patch set adding
Hi Vasant,
On 07/28/2015 07:40 PM, Jacek Anaszewski wrote:
Vasant,
On 28.07.2015 15:40, Vasant Hegde wrote:
On 07/27/2015 03:20 PM, Jacek Anaszewski wrote:
Hi Vasant,
On 27.07.2015 05:41, Vasant Hegde wrote:
On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
Two
On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote:
+/* Register the classdev */
+rc = devm_led_classdev_register(dev, powernv_led-cdev);
+if (rc) {
+dev_err(dev, %s: Classdev registration failed for %s\n,
+__func__, powernv_led-cdev.name);
+}
On 07/27/2015 03:20 PM, Jacek Anaszewski wrote:
Hi Vasant,
On 27.07.2015 05:41, Vasant Hegde wrote:
On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
Two trivial details left. Please find them below.
Thanks for the review/Ack. I'll fix below issues and resend
On 28.07.2015 12:14, Benjamin Herrenschmidt wrote:
On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote:
+/* Register the classdev */
+rc = devm_led_classdev_register(dev, powernv_led-cdev);
+if (rc) {
+dev_err(dev, %s: Classdev registration failed for %s\n,
+
Vasant,
On 28.07.2015 15:40, Vasant Hegde wrote:
On 07/27/2015 03:20 PM, Jacek Anaszewski wrote:
Hi Vasant,
On 27.07.2015 05:41, Vasant Hegde wrote:
On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
Two trivial details left. Please find them below.
Thanks for the
Vasant,
I've found one more formatting issue below.
On 27.07.2015 05:41, Vasant Hegde wrote:
[...]
+
+/*
+ * This function registers classdev structure for any given type of LED on
+ * a given child LED device node.
+ */
+static int powernv_led_create(struct device *dev,
+
Hi Vasant,
On 27.07.2015 05:41, Vasant Hegde wrote:
On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
Two trivial details left. Please find them below.
Thanks for the review/Ack. I'll fix below issues and resend patchset.
I will ask Benh/Michael to take this
Hi Vasant,
Two trivial details left. Please find them below.
Since for two next weeks I will be unable even to compile-test
this patch set I propose to merge it via powerpc tree.
Having both mentioned issues addressed, for this patch:
Acked-by: Jacek Anaszewski j.anaszew...@samsung.com
On
On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
Hi Vasant,
Hi Jacek,
Two trivial details left. Please find them below.
Thanks for the review/Ack. I'll fix below issues and resend patchset.
I will ask Benh/Michael to take this patchset. But this patchset is depending
on your core changes.
This patch implements LED driver for PowerNV platform using the existing
generic LED class framework.
PowerNV platform has below type of LEDs:
- System attention
Indicates there is a problem with the system that needs attention.
- Identify
Helps the user locate/identify a
11 matches
Mail list logo
