Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-08 Thread york sun
On 08/05/2016 12:01 AM, Borislav Petkov wrote: > On Fri, Aug 05, 2016 at 04:26:26AM +, york sun wrote: >> I don't have deep knowledge of this driver. What I am trying is to >> separate the common DDR part and share it with ARM platforms. Along the >> way, I found the compiling error if build a

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread Scott Wood
On Fri, 2016-08-05 at 21:20 +, york sun wrote: > On 08/05/2016 02:09 PM, Scott Wood wrote: > > > > On Fri, 2016-08-05 at 20:29 +, york sun wrote: > > > > > > On 08/04/2016 08:43 PM, Michael Ellerman wrote: > > > > > > > > > > > > Does the driver really need to use these routines?

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread york sun
On 08/05/2016 02:09 PM, Scott Wood wrote: > On Fri, 2016-08-05 at 20:29 +, york sun wrote: >> On 08/04/2016 08:43 PM, Michael Ellerman wrote: >>> >>> Does the driver really need to use these routines? They're meant for use >>> early in boot, before PCI is setup. >>> >>> AFAICS this is just a

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread Scott Wood
On Fri, 2016-08-05 at 20:29 +, york sun wrote: > On 08/04/2016 08:43 PM, Michael Ellerman wrote: > > > > Does the driver really need to use these routines? They're meant for use > > early in boot, before PCI is setup. > > > > AFAICS this is just a regular driver, so when it's probed the PCI

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread york sun
On 08/04/2016 08:43 PM, Michael Ellerman wrote: > York Sun writes: > >> Two symbols are missing if mpc85xx_edac driver is compiled as module. >> >> Signed-off-by: York Sun >> >> --- >> Change log >> v3: Change subject tag >> v2: no change >> >>

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread york sun
On 08/04/2016 04:36 PM, Andrew Donnellan wrote: > On 05/08/16 08:58, York Sun wrote: >> Two symbols are missing if mpc85xx_edac driver is compiled as module. >> >> Signed-off-by: York Sun > > Good catch! One comment below. > > Reviewed-by: Andrew Donnellan

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread Johannes Thumshirn
On Fri, Aug 05, 2016 at 09:01:26AM +0200, Borislav Petkov wrote: > On Fri, Aug 05, 2016 at 04:26:26AM +, york sun wrote: > > I don't have deep knowledge of this driver. What I am trying is to > > separate the common DDR part and share it with ARM platforms. Along the > > way, I found the

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread Borislav Petkov
On Fri, Aug 05, 2016 at 04:26:26AM +, york sun wrote: > I don't have deep knowledge of this driver. What I am trying is to > separate the common DDR part and share it with ARM platforms. Along the > way, I found the compiling error if build a module. If exposing these > functions becomes a

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread Borislav Petkov
On Thu, Aug 04, 2016 at 11:39:14PM +, york sun wrote: > I will rename it if I respin this patch for any reason. Otherwise, I > will send out another patch to rename it after merging. Feel free to send an updated one as a reply to this thread. -- Regards/Gruss, Boris. ECO tip #101:

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-05 Thread york sun
On 08/04/2016 08:43 PM, Michael Ellerman wrote: > York Sun writes: > >> Two symbols are missing if mpc85xx_edac driver is compiled as module. >> >> Signed-off-by: York Sun >> >> --- >> Change log >> v3: Change subject tag >> v2: no change >> >>

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread Michael Ellerman
York Sun writes: > Two symbols are missing if mpc85xx_edac driver is compiled as module. > > Signed-off-by: York Sun > > --- > Change log > v3: Change subject tag > v2: no change > > arch/powerpc/kernel/pci-common.c | 2 ++ > 1 file changed, 2

[Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread York Sun
Two symbols are missing if mpc85xx_edac driver is compiled as module. Signed-off-by: York Sun --- Change log v3: Change subject tag v2: no change arch/powerpc/kernel/pci-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/kernel/pci-common.c

Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac

2016-08-04 Thread Andrew Donnellan
On 05/08/16 08:58, York Sun wrote: Two symbols are missing if mpc85xx_edac driver is compiled as module. Signed-off-by: York Sun Good catch! One comment below. Reviewed-by: Andrew Donnellan /* * Reads the interrupt pin to determine if