On Wed, 21 May 2014, Joonsoo Kim wrote:

> Currently, if allocation constraint to node is NUMA_NO_NODE, we search
> a partial slab on numa_node_id() node. This doesn't work properly on the
> system having memoryless node, since it can have no memory on that node and
> there must be no partial slab on that node.
> 
> On that node, page allocation always fallback to numa_mem_id() first. So
> searching a partial slab on numa_node_id() in that case is proper solution
> for memoryless node case.
> 
> Acked-by: Nishanth Aravamudan <n...@linux.vnet.ibm.com>
> Acked-by: David Rientjes <rient...@google.com>
> Acked-by: Christoph Lameter <c...@linux.com>
> Signed-off-by: Joonsoo Kim <iamjoonsoo....@lge.com>
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 545a170..cc1f995 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1698,7 +1698,7 @@ static void *get_partial(struct kmem_cache *s, gfp_t 
> flags, int node,
>               struct kmem_cache_cpu *c)
>  {
>       void *object;
> -     int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node;
> +     int searchnode = (node == NUMA_NO_NODE) ? numa_mem_id() : node;
>  
>       object = get_partial_node(s, get_node(s, searchnode), c, flags);
>       if (object || node != NUMA_NO_NODE)

Andrew, can you merge this please?  It's still not in linux-next.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to