Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-05 Thread Dan Williams
On Fri, Jun 5, 2020 at 8:22 AM Vaibhav Jain wrote: [..] > > Oh, why not define a maximal health payload with all the attributes > > you know about today, leave some room for future expansion, and then > > report a validity flag for each attribute? This is how the "intel" > > smart-health payload

RE: [RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-05 Thread Vaibhav Jain
Cc: Santosh Sivaraj ; Aneesh Kumar K . V >> ; Steven Rostedt ; >> Oliver O'Halloran ; Weiny, Ira >> Subject: RE: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for >> PAPR nvdimm specific methods >> >> Hi Dan, >> >> Thanks for review and i

RE: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-04 Thread Williams, Dan J
dt ; > Oliver O'Halloran ; Weiny, Ira > Subject: RE: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for > PAPR nvdimm specific methods > > Hi Dan, > > Thanks for review and insights on this. My responses below: > > "Williams, Dan J" writes: > > &

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-04 Thread Vaibhav Jain
Ira Weiny writes: > On Wed, Jun 03, 2020 at 11:41:42PM +0530, Vaibhav Jain wrote: >> Hi Ira, >> >> Thanks for reviewing this patch. My responses below: >> >> Ira Weiny writes: >> > > ... > >> >> + * >> >> + * Payload Version: >> >> + * >> >> + * A 'payload_version' field is present in PDSM

RE: [RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-04 Thread Vaibhav Jain
Hi Dan, Thanks for review and insights on this. My responses below: "Williams, Dan J" writes: > [ forgive formatting I'm temporarily stuck using Outlook this week... ] > >> From: Vaibhav Jain > [..] >> >> Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm >> module and add

RE: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Williams, Dan J
[ forgive formatting I'm temporarily stuck using Outlook this week... ] > From: Vaibhav Jain [..] > > Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm > module and add the command family NVDIMM_FAMILY_PAPR to the white > list of NVDIMM command sets. Also advertise support

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Ira Weiny
On Thu, Jun 04, 2020 at 01:58:00AM +0530, Vaibhav Jain wrote: > Hi Ira, > > Thanks again for reviewing this patch. My Response below: > > Ira Weiny writes: > > > On Tue, Jun 02, 2020 at 01:51:49PM -0700, 'Ira Weiny' wrote: > >> On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: > >

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Ira Weiny
On Wed, Jun 03, 2020 at 11:41:42PM +0530, Vaibhav Jain wrote: > Hi Ira, > > Thanks for reviewing this patch. My responses below: > > Ira Weiny writes: > ... > >> + * > >> + * Payload Version: > >> + * > >> + * A 'payload_version' field is present in PDSM header that indicates a > >>

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks again for reviewing this patch. My Response below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 01:51:49PM -0700, 'Ira Weiny' wrote: >> On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: > > ... > >> > + >> > +/* >> > + * PDSM Envelope: >> > + * >> > + * The ioctl

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks for reviewing this patch. My responses below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: >> Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm >> module and add the command family NVDIMM_FAMILY_PAPR to the white list >>

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-02 Thread Ira Weiny
On Tue, Jun 02, 2020 at 01:51:49PM -0700, 'Ira Weiny' wrote: > On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: ... > > + > > +/* > > + * PDSM Envelope: > > + * > > + * The ioctl ND_CMD_CALL transfers data between user-space and kernel via > > + * envelope which consists of a header

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-02 Thread Ira Weiny
On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: > Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm > module and add the command family NVDIMM_FAMILY_PAPR to the white list > of NVDIMM command sets. Also advertise support for ND_CMD_CALL for the > nvdimm command

[RESEND PATCH v9 4/5] ndctl/papr_scm, uapi: Add support for PAPR nvdimm specific methods

2020-06-02 Thread Vaibhav Jain
Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm module and add the command family NVDIMM_FAMILY_PAPR to the white list of NVDIMM command sets. Also advertise support for ND_CMD_CALL for the nvdimm command mask and implement necessary scaffolding in the module to handle