[RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata [take 2]

2008-10-14 Thread Vitaly Bordug
A published errata for ppc440epx states, that when running Linux with both EHCI and OHCI modules loaded, the EHCI module experiences a fatal error when a high-speed device is connected to the USB2.0, and functions normally if OHCI module is not loaded. There used to be recommendation to use only

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata [take 2]

2008-10-14 Thread Alan Stern
On Tue, 14 Oct 2008, Vitaly Bordug wrote: A published errata for ppc440epx states, that when running Linux with both EHCI and OHCI modules loaded, the EHCI module experiences a fatal error when a high-speed device is connected to the USB2.0, and functions normally if OHCI module is not

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata [take 2]

2008-10-14 Thread Vitaly Bordug
Have you tried building this on a non-PPC440EPx system? It looks like this patch would cause a compile error. yes, correct, last minute fix didn't make it into the patch, sorry about that. Will refresh, test and resubmit. -Vitaly ___ Linuxppc-dev

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-09-06 Thread Vitaly Bordug
В Fri, 5 Sep 2008 11:17:03 -0400 (EDT) Alan Stern [EMAIL PROTECTED] пишет: On Fri, 5 Sep 2008, Vitaly Bordug wrote: Not every hub will work (none of available did so far), and it is often not an option for embedded device without rewiring. It's odd that your hubs don't work.

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-09-05 Thread Vitaly Bordug
В Thu, 4 Sep 2008 17:40:49 -0400 (EDT) Alan Stern [EMAIL PROTECTED] пишет: On Fri, 5 Sep 2008, Vitaly Bordug wrote: I've started looking this way. Sorry, but this approach is a little bit fragile, and unreliable. First, it just did not work out in case of usb2 hub with memory stick

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-09-05 Thread Alan Stern
On Fri, 5 Sep 2008, Vitaly Bordug wrote: Not every hub will work (none of available did so far), and it is often not an option for embedded device without rewiring. It's odd that your hubs don't work. What's wrong with them? well, they do not have transaction translators then.

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-09-04 Thread Vitaly Bordug
В Fri, 29 Aug 2008 17:30:57 -0400 (EDT) Alan Stern [EMAIL PROTECTED] пишет: On Fri, 29 Aug 2008, Vitaly Bordug wrote: But even assuming PM set, common use-case of embedded systems to have stuff on USB bus that is never plugged off; and in case of compiled-in ehci and ohci there is just

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-09-04 Thread Alan Stern
On Fri, 5 Sep 2008, Vitaly Bordug wrote: I've started looking this way. Sorry, but this approach is a little bit fragile, and unreliable. First, it just did not work out in case of usb2 hub with memory stick and keybord plugged - OHCI did not suspend, ehci is hosed and we're happily using

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-09-04 Thread Benjamin Herrenschmidt
I assume that's the reason the suggested approach failed. I think (hope) that Vitaly actually fixed that before trying it :-) I don't mind doing that, provided the changes are cleaned up so that they don't affect people who aren't building kernels for 44x systems. I also find the CONFIG_PM

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-29 Thread Steven A. Falco
Alan Stern wrote: On Thu, 28 Aug 2008, Steven A. Falco wrote: Alan Stern wrote: Your original post mentioned that the 440EPx has only one USB 2.0 host port. Then how can you use a keyboard and memory stick at the same time? You'd have to plug them into a hub -- in which case only one

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-29 Thread Alan Stern
On Fri, 29 Aug 2008, Benjamin Herrenschmidt wrote: I suppose some embedded platforms don't use CONFIG_PM, is this still a requirement for autosuspend ? Or do that happen always on an empty port nowadays ? ohci-hcd doesn't automatically suspend the root hub if CONFIG_PM isn't set. However it

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-29 Thread Matthias Fuchs
Hi, please see my comment below. It might be helpful for some of you. On Thursday 28 August 2008 23:11:51 Steven A. Falco wrote: Alan Stern wrote: Your original post mentioned that the 440EPx has only one USB 2.0 host port. Then how can you use a keyboard and memory stick at the same

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-29 Thread Vitaly Bordug
В Fri, 29 Aug 2008 11:26:07 -0400 (EDT) Alan Stern [EMAIL PROTECTED] пишет: On Fri, 29 Aug 2008, Benjamin Herrenschmidt wrote: I suppose some embedded platforms don't use CONFIG_PM, is this still a requirement for autosuspend ? Or do that happen always on an empty port nowadays ?

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-29 Thread Alan Stern
On Fri, 29 Aug 2008, Vitaly Bordug wrote: But even assuming PM set, common use-case of embedded systems to have stuff on USB bus that is never plugged off; and in case of compiled-in ehci and ohci there is just Initializing USB Mass Storage driver... usb 1-1: new high speed USB device

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-28 Thread Vitaly Bordug
В Wed, 27 Aug 2008 10:36:20 -0400 (EDT) Alan Stern [EMAIL PROTECTED] пишет: On Wed, 27 Aug 2008, Vitaly Bordug wrote: A published errata for ppc440epx states, that when running Linux with both EHCI and OHCI modules loaded, the EHCI module experiences a fatal error when a high-speed

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-28 Thread Alan Stern
On Thu, 28 Aug 2008, Vitaly Bordug wrote: This doesn't explain why the fatal error occurs. On certain 44x set of SoCs, only one controller is able to function, e.g. technically they are mutually exclusive. There used to be recommendation to use only hi-speed or full-speed devices with

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-28 Thread Steven A. Falco
Alan Stern wrote: Your original post mentioned that the 440EPx has only one USB 2.0 host port. Then how can you use a keyboard and memory stick at the same time? You'd have to plug them into a hub -- in which case only one controller would be needed, the one driving the hub. The patch would

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-28 Thread Alan Stern
On Thu, 28 Aug 2008, Steven A. Falco wrote: Alan Stern wrote: Your original post mentioned that the 440EPx has only one USB 2.0 host port. Then how can you use a keyboard and memory stick at the same time? You'd have to plug them into a hub -- in which case only one controller would be

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-28 Thread Benjamin Herrenschmidt
On Thu, 2008-08-28 at 17:33 -0400, Alan Stern wrote: Is there some reason why it doesn't work already? All the patch does is suspend the OHCI root hub when you plug in the memory stick -- but the root hub should already be suspended. Unless the memory stick is already plugged in when the

Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-27 Thread Alan Stern
On Wed, 27 Aug 2008, Vitaly Bordug wrote: A published errata for ppc440epx states, that when running Linux with both EHCI and OHCI modules loaded, the EHCI module experiences a fatal error when a high-speed device is connected to the USB2.0, and functions normally if OHCI module is not

[RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata

2008-08-26 Thread Vitaly Bordug
A published errata for ppc440epx states, that when running Linux with both EHCI and OHCI modules loaded, the EHCI module experiences a fatal error when a high-speed device is connected to the USB2.0, and functions normally if OHCI module is not loaded. Quote from original descriprion: The