Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-02-17 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Wed, 27 Jan 2010 13:10:56 +1100 I'll try do make ppc catch up with some of that see how it goes. FWIW I'm taking care of syncing up sparc in this area right now. I just noticed the -dma_mask assignment got moved as well. Really, any

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-02-17 Thread Jesse Barnes
On Wed, 17 Feb 2010 16:22:59 -0800 (PST) David Miller da...@davemloft.net wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Wed, 27 Jan 2010 13:10:56 +1100 I'll try do make ppc catch up with some of that see how it goes. FWIW I'm taking care of syncing up sparc in this

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-28 Thread Matthew Wilcox
On Wed, Jan 27, 2010 at 01:10:56PM +1100, Benjamin Herrenschmidt wrote: Cc'ing Ben for PPC. Ben, should PPC use pci_scan_device when probing its root busses? Sounds like it just uses pci_device_add for each one it finds instead? If you don't actually need scanning (though what about

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-28 Thread Benjamin Herrenschmidt
On Thu, 2010-01-28 at 20:45 -0700, Matthew Wilcox wrote: This is also probably going to be moved to a more generic place and extended to be used optionally by other architectures. Yes, having it under drivers/pci/ somewhere would be a big improvement, that way we'd actually see it when

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-27 Thread Jesse Barnes
On Wed, 27 Jan 2010 13:10:56 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Cc'ing Ben for PPC. Ben, should PPC use pci_scan_device when probing its root busses? Sounds like it just uses pci_device_add for each one it finds instead? If you don't actually need scanning

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-27 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Thu, 28 Jan 2010 09:00:12 +1100 On Wed, 2010-01-27 at 08:26 -0800, Jesse Barnes wrote: Thanks Ben. Any refactoring we need to handle this stuff better is fine with me too. I guess on some platforms calling pci_setup_device may

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-27 Thread Jesse Barnes
On Wed, 27 Jan 2010 16:01:21 -0800 (PST) David Miller da...@davemloft.net wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Thu, 28 Jan 2010 09:00:12 +1100 On Wed, 2010-01-27 at 08:26 -0800, Jesse Barnes wrote: Thanks Ben. Any refactoring we need to handle this stuff

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-26 Thread Benjamin Herrenschmidt
Cc'ing Ben for PPC. Ben, should PPC use pci_scan_device when probing its root busses? Sounds like it just uses pci_device_add for each one it finds instead? If you don't actually need scanning (though what about hotplug?) we can move the call to device_add instead... Ok so I looked at

[RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Breno Leitao
Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev-pcie is not set on PPC, because the function set_pcie_port_type(), who sets dev-pcie, is not being called on PPC PCI code. So, I have two ideas to fix it,

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Jesse Barnes
On Mon, 25 Jan 2010 11:42:29 -0200 Breno Leitao lei...@linux.vnet.ibm.com wrote: Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev-pcie is not set on PPC, because the function set_pcie_port_type(),

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Jesse Barnes
On Mon, 25 Jan 2010 12:38:49 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 25 Jan 2010 11:42:29 -0200 Breno Leitao lei...@linux.vnet.ibm.com wrote: Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Benjamin Herrenschmidt
On Mon, 2010-01-25 at 17:50 -0800, Jesse Barnes wrote: You mean dev-is_pcie? Why isn't pci_scan_device calling pci_setup_device for you? That should do the proper PCIe init depending on the device, along with extracting other device info... Cc'ing Ben for PPC. Ben, should PPC use

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Kenji Kaneshige
Breno Leitao wrote: Hello, I found that qlge is broken on PPC, and it got broken after commit 06a1cbafb253c4c60d6a54a994887f5fbceabcc0. It happens because dev-pcie is not set on PPC, because the function set_pcie_port_type(), who sets dev-pcie, is not being called on PPC PCI code. Hi

Re: [RFC PATCH] PCI-E broken on PPC (regression)

2010-01-25 Thread Kenji Kaneshige
Jesse Barnes wrote: On Mon, 25 Jan 2010 12:38:49 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 25 Jan 2010 11:42:29 -0200 Breno Leitao lei...@linux.vnet.ibm.com wrote: Hello, I found that qlge is broken on PPC, and it got broken after commit