Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

2015-10-22 Thread Michael Turquette 
Quoting Scott Wood (2015-10-09 16:57:44)
> On Thu, 2015-10-01 at 19:26 -0500, Scott Wood wrote:
> > [Resending to updated e-mail address]
> > 
> > On Tue, 2015-08-11 at 11:25 -0700, Michael Turquette wrote:
> > > Hi Scott,
> > > 
> > > Quoting Scott Wood (2015-06-18 19:49:10)
> > > > The existing device tree bindings are error-prone and inflexible. 
> > > > Correct the mistake by moving the knowledge into the driver, which
> > > > has more flexibility in describing the quirks of each chip.  This leaves
> > > > the device tree to its proper role of identifying a programming 
> > > > interface
> > > > rather than describing its individual registers.
> > > 
> > > Sorry for not responding to this one sooner. Fell through the cracks.
> > > 
> > > All of the changes to drives/clk/clk-qoriq.c look great to me. I assume
> > > you need to keep all of these patches together and want to the take
> > > through the freescale tree? If so feel free to add,
> > > 
> > > Acked-by: Michael Turquette 
> > 
> > Is the ack still valid for the v3 patchset?

Yes. Looks Stephen beat me to it though.

Regards,
Mike

> 
> ping
> 
> -Scott
> 
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

2015-10-09 Thread Scott Wood 
On Thu, 2015-10-01 at 19:26 -0500, Scott Wood wrote:
> [Resending to updated e-mail address]
> 
> On Tue, 2015-08-11 at 11:25 -0700, Michael Turquette wrote:
> > Hi Scott,
> > 
> > Quoting Scott Wood (2015-06-18 19:49:10)
> > > The existing device tree bindings are error-prone and inflexible. 
> > > Correct the mistake by moving the knowledge into the driver, which
> > > has more flexibility in describing the quirks of each chip.  This leaves
> > > the device tree to its proper role of identifying a programming 
> > > interface
> > > rather than describing its individual registers.
> > 
> > Sorry for not responding to this one sooner. Fell through the cracks.
> > 
> > All of the changes to drives/clk/clk-qoriq.c look great to me. I assume
> > you need to keep all of these patches together and want to the take
> > through the freescale tree? If so feel free to add,
> > 
> > Acked-by: Michael Turquette 
> 
> Is the ack still valid for the v3 patchset?

ping

-Scott

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

2015-10-01 Thread Scott Wood 
[Resending to updated e-mail address]

On Tue, 2015-08-11 at 11:25 -0700, Michael Turquette wrote:
> Hi Scott,
> 
> Quoting Scott Wood (2015-06-18 19:49:10)
> > The existing device tree bindings are error-prone and inflexible. 
> > Correct the mistake by moving the knowledge into the driver, which
> > has more flexibility in describing the quirks of each chip.  This leaves
> > the device tree to its proper role of identifying a programming interface
> > rather than describing its individual registers.
> 
> Sorry for not responding to this one sooner. Fell through the cracks.
> 
> All of the changes to drives/clk/clk-qoriq.c look great to me. I assume
> you need to keep all of these patches together and want to the take
> through the freescale tree? If so feel free to add,
> 
> Acked-by: Michael Turquette 

Is the ack still valid for the v3 patchset?

-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

2015-10-01 Thread Scott Wood 
On Tue, 2015-08-11 at 11:25 -0700, Michael Turquette wrote:
> Hi Scott,
> 
> Quoting Scott Wood (2015-06-18 19:49:10)
> > The existing device tree bindings are error-prone and inflexible. 
> > Correct the mistake by moving the knowledge into the driver, which
> > has more flexibility in describing the quirks of each chip.  This leaves
> > the device tree to its proper role of identifying a programming interface
> > rather than describing its individual registers.
> 
> Sorry for not responding to this one sooner. Fell through the cracks.
> 
> All of the changes to drives/clk/clk-qoriq.c look great to me. I assume
> you need to keep all of these patches together and want to the take
> through the freescale tree? If so feel free to add,
> 
> Acked-by: Michael Turquette 

Is the ack still valid for the v3 patchset?

-Scott

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

2015-08-15 Thread Scott Wood 
On Tue, 2015-08-11 at 11:25 -0700, Michael Turquette wrote:
 Hi Scott,
 
 Quoting Scott Wood (2015-06-18 19:49:10)
  The existing device tree bindings are error-prone and inflexible. 
  Correct the mistake by moving the knowledge into the driver, which
  has more flexibility in describing the quirks of each chip.  This leaves
  the device tree to its proper role of identifying a programming interface
  rather than describing its individual registers.
 
 Sorry for not responding to this one sooner. Fell through the cracks.
 
 All of the changes to drives/clk/clk-qoriq.c look great to me. I assume
 you need to keep all of these patches together and want to the take
 through the freescale tree? If so feel free to add,
 
 Acked-by: Michael Turquette mturque...@baylibre.com

I just sent a non-RFC v2, with improved compatibility with old device trees 
(especially ls1021a).  It depends on the cpufreq patch though (at least, to 
avoid breaking qoriq-cpufreq until that patch is merged), so I'll also need 
an ack from Rafael for that if I'm taking it through my tree.

-Scott

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

2015-08-11 Thread Michael Turquette 
Hi Scott,

Quoting Scott Wood (2015-06-18 19:49:10)
 The existing device tree bindings are error-prone and inflexible. 
 Correct the mistake by moving the knowledge into the driver, which
 has more flexibility in describing the quirks of each chip.  This leaves
 the device tree to its proper role of identifying a programming interface
 rather than describing its individual registers.

Sorry for not responding to this one sooner. Fell through the cracks.

All of the changes to drives/clk/clk-qoriq.c look great to me. I assume
you need to keep all of these patches together and want to the take
through the freescale tree? If so feel free to add,

Acked-by: Michael Turquette mturque...@baylibre.com

Regards,
Mike

 
 For more detail, see the commit message of patch 4.
 
 Scott Wood (8):
   ARM: dts: ls1021a: Fix clockgen node
   cpufreq: qoriq: Don't look at clock implementation details
   powerpc/fsl: Move fsl_guts.h out of arch/powerpc
   clk: qoriq: Move chip-specific knowledge into driver
   clk: qoriq: Redirect legacy clock nodes to new clocks
   cpufreq: qoriq: Remove frequency masking and minimum
   clk: qoriq: Expose OF clocks directly from the clockgen node
   powerpc/fsl: Use new clockgen binding
 
  .../devicetree/bindings/clock/qoriq-clock.txt  |   57 +-
  arch/arm/boot/dts/ls1021a.dtsi |3 +
  arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi |4 +-
  arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi |8 +-
  arch/powerpc/boot/dts/fsl/b4si-post.dtsi   |   15 -
  arch/powerpc/boot/dts/fsl/p2041si-post.dtsi|   18 -
  arch/powerpc/boot/dts/fsl/p2041si-pre.dtsi |8 +-
  arch/powerpc/boot/dts/fsl/p3041si-post.dtsi|   18 -
  arch/powerpc/boot/dts/fsl/p3041si-pre.dtsi |8 +-
  arch/powerpc/boot/dts/fsl/p4080si-post.dtsi|   70 --
  arch/powerpc/boot/dts/fsl/p4080si-pre.dtsi |   16 +-
  arch/powerpc/boot/dts/fsl/p5020si-pre.dtsi |4 +-
  arch/powerpc/boot/dts/fsl/p5040si-post.dtsi|   18 -
  arch/powerpc/boot/dts/fsl/p5040si-pre.dtsi |8 +-
  arch/powerpc/boot/dts/fsl/qoriq-clockgen1.dtsi |   50 +-
  arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi |   33 +-
  arch/powerpc/boot/dts/fsl/t1023si-post.dtsi|   16 -
  arch/powerpc/boot/dts/fsl/t102xsi-pre.dtsi |4 +-
  arch/powerpc/boot/dts/fsl/t1040si-post.dtsi|   44 -
  arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi |8 +-
  arch/powerpc/boot/dts/fsl/t2081si-post.dtsi|   22 -
  arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi |8 +-
  arch/powerpc/boot/dts/fsl/t4240si-post.dtsi|   61 -
  arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi |   24 +-
  arch/powerpc/platforms/85xx/mpc85xx_mds.c  |2 +-
  arch/powerpc/platforms/85xx/mpc85xx_rdb.c  |2 +-
  arch/powerpc/platforms/85xx/p1022_ds.c |2 +-
  arch/powerpc/platforms/85xx/p1022_rdk.c|2 +-
  arch/powerpc/platforms/85xx/smp.c  |2 +-
  arch/powerpc/platforms/85xx/twr_p102x.c|2 +-
  arch/powerpc/platforms/86xx/mpc8610_hpcd.c |2 +-
  drivers/clk/clk-qoriq.c| 1191 
 
  drivers/cpufreq/qoriq-cpufreq.c|  139 +--
  drivers/iommu/fsl_pamu.c   |2 +-
  .../asm/fsl_guts.h = include/linux/fsl/guts.h |6 +-
  sound/soc/fsl/mpc8610_hpcd.c   |2 +-
  sound/soc/fsl/p1022_ds.c   |2 +-
  sound/soc/fsl/p1022_rdk.c  |2 +-
  38 files changed, 1107 insertions(+), 776 deletions(-)
  rename arch/powerpc/include/asm/fsl_guts.h = include/linux/fsl/guts.h (98%)
 
 -- 
 2.1.4
 
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[RFC PATCH 0/8] clk: qoriq: Move chip-specific knowledge into driver

2015-06-18 Thread Scott Wood 
The existing device tree bindings are error-prone and inflexible. 
Correct the mistake by moving the knowledge into the driver, which
has more flexibility in describing the quirks of each chip.  This leaves
the device tree to its proper role of identifying a programming interface
rather than describing its individual registers.

For more detail, see the commit message of patch 4.

Scott Wood (8):
  ARM: dts: ls1021a: Fix clockgen node
  cpufreq: qoriq: Don't look at clock implementation details
  powerpc/fsl: Move fsl_guts.h out of arch/powerpc
  clk: qoriq: Move chip-specific knowledge into driver
  clk: qoriq: Redirect legacy clock nodes to new clocks
  cpufreq: qoriq: Remove frequency masking and minimum
  clk: qoriq: Expose OF clocks directly from the clockgen node
  powerpc/fsl: Use new clockgen binding

 .../devicetree/bindings/clock/qoriq-clock.txt  |   57 +-
 arch/arm/boot/dts/ls1021a.dtsi |3 +
 arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi |4 +-
 arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi |8 +-
 arch/powerpc/boot/dts/fsl/b4si-post.dtsi   |   15 -
 arch/powerpc/boot/dts/fsl/p2041si-post.dtsi|   18 -
 arch/powerpc/boot/dts/fsl/p2041si-pre.dtsi |8 +-
 arch/powerpc/boot/dts/fsl/p3041si-post.dtsi|   18 -
 arch/powerpc/boot/dts/fsl/p3041si-pre.dtsi |8 +-
 arch/powerpc/boot/dts/fsl/p4080si-post.dtsi|   70 --
 arch/powerpc/boot/dts/fsl/p4080si-pre.dtsi |   16 +-
 arch/powerpc/boot/dts/fsl/p5020si-pre.dtsi |4 +-
 arch/powerpc/boot/dts/fsl/p5040si-post.dtsi|   18 -
 arch/powerpc/boot/dts/fsl/p5040si-pre.dtsi |8 +-
 arch/powerpc/boot/dts/fsl/qoriq-clockgen1.dtsi |   50 +-
 arch/powerpc/boot/dts/fsl/qoriq-clockgen2.dtsi |   33 +-
 arch/powerpc/boot/dts/fsl/t1023si-post.dtsi|   16 -
 arch/powerpc/boot/dts/fsl/t102xsi-pre.dtsi |4 +-
 arch/powerpc/boot/dts/fsl/t1040si-post.dtsi|   44 -
 arch/powerpc/boot/dts/fsl/t104xsi-pre.dtsi |8 +-
 arch/powerpc/boot/dts/fsl/t2081si-post.dtsi|   22 -
 arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi |8 +-
 arch/powerpc/boot/dts/fsl/t4240si-post.dtsi|   61 -
 arch/powerpc/boot/dts/fsl/t4240si-pre.dtsi |   24 +-
 arch/powerpc/platforms/85xx/mpc85xx_mds.c  |2 +-
 arch/powerpc/platforms/85xx/mpc85xx_rdb.c  |2 +-
 arch/powerpc/platforms/85xx/p1022_ds.c |2 +-
 arch/powerpc/platforms/85xx/p1022_rdk.c|2 +-
 arch/powerpc/platforms/85xx/smp.c  |2 +-
 arch/powerpc/platforms/85xx/twr_p102x.c|2 +-
 arch/powerpc/platforms/86xx/mpc8610_hpcd.c |2 +-
 drivers/clk/clk-qoriq.c| 1191 
 drivers/cpufreq/qoriq-cpufreq.c|  139 +--
 drivers/iommu/fsl_pamu.c   |2 +-
 .../asm/fsl_guts.h = include/linux/fsl/guts.h |6 +-
 sound/soc/fsl/mpc8610_hpcd.c   |2 +-
 sound/soc/fsl/p1022_ds.c   |2 +-
 sound/soc/fsl/p1022_rdk.c  |2 +-
 38 files changed, 1107 insertions(+), 776 deletions(-)
 rename arch/powerpc/include/asm/fsl_guts.h = include/linux/fsl/guts.h (98%)

-- 
2.1.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev