Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-26 Thread Albert Herranz
Benjamin Herrenschmidt wrote: On Sun, 2009-11-22 at 23:01 +0100, Albert Herranz wrote: +static void hlwd_pic_mask_and_ack(unsigned int virq) +{ +int irq = virq_to_hw(virq); +void __iomem *io_base = get_irq_chip_data(virq); + +clear_bit(irq, io_base + HW_BROADWAY_IMR); +

Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-26 Thread Benjamin Herrenschmidt
On Thu, 2009-11-26 at 16:42 +0100, Albert Herranz wrote: Benjamin Herrenschmidt wrote: On Sun, 2009-11-22 at 23:01 +0100, Albert Herranz wrote: +static void hlwd_pic_mask_and_ack(unsigned int virq) +{ + int irq = virq_to_hw(virq); + void __iomem *io_base = get_irq_chip_data(virq);

Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-26 Thread Segher Boessenkool
+static void hlwd_pic_mask_and_ack(unsigned int virq) +{ + int irq = virq_to_hw(virq); + void __iomem *io_base = get_irq_chip_data(virq); + + clear_bit(irq, io_base + HW_BROADWAY_IMR); + set_bit(irq, io_base + HW_BROADWAY_ICR); +} Same comment as with flipper. BTW. It

Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-25 Thread Albert Herranz
Segher Boessenkool wrote: +config HLWD_PIC Are vowels too expensive? :-) Heh, you work/worked for IBM. Look at what they did with the CLI in the AS/400... I thought here that hollywood is a rather large prefix and there is also a board called holly. So I came up with hlwd :) +static

Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-25 Thread Benjamin Herrenschmidt
On Sun, 2009-11-22 at 23:01 +0100, Albert Herranz wrote: +static void hlwd_pic_mask_and_ack(unsigned int virq) +{ + int irq = virq_to_hw(virq); + void __iomem *io_base = get_irq_chip_data(virq); + + clear_bit(irq, io_base + HW_BROADWAY_IMR); + set_bit(irq, io_base +

Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-24 Thread Segher Boessenkool
+config HLWD_PIC Are vowels too expensive? :-) +static void hlwd_pic_ack(unsigned int virq) +{ + int irq = virq_to_hw(virq); + void __iomem *io_base = get_irq_chip_data(virq); + + set_bit(irq, io_base + HW_BROADWAY_ICR); +} Same issue as with Flipper here. +

Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-23 Thread Albert Herranz
Grant Likely wrote: On Sun, Nov 22, 2009 at 3:01 PM, Albert Herranz albert_herr...@yahoo.es wrote: Add support for the dual interrupt controller included in the Hollywood chipset of the Nintendo Wii video game console. This interrupt controller serves both the Broadway processor (as a

[RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-22 Thread Albert Herranz
Add support for the dual interrupt controller included in the Hollywood chipset of the Nintendo Wii video game console. This interrupt controller serves both the Broadway processor (as a cascade) and the Starlet processor, and is used to manage interrupts for the non-classic hardware.

Re: [RFC PATCH 16/19] powerpc: wii: hollywood interrupt controller support

2009-11-22 Thread Grant Likely
On Sun, Nov 22, 2009 at 3:01 PM, Albert Herranz albert_herr...@yahoo.es wrote: Add support for the dual interrupt controller included in the Hollywood chipset of the Nintendo Wii video game console. This interrupt controller serves both the Broadway processor (as a cascade) and the Starlet