Hi Grant,
+ - compatible : should be linux,mmc-spi.
+ - linux,modalias - should be of_mmc_spi.
I'm not even sure if the whole linux,modalias is even a good idea. I
had kind of thrown it in there as a convenient way to override
compatible when needed, but I haven't really
+ Required properties:
+ - #address-cells : should be 0.
+ - #size-cells : should be 0.
Are these properties required at all? Will this node have any
children.
You mean, does this node define a bus. If it doesn't, there
shouldn't be #a and #s; if it does, the binding should
The real problem is we don't yet have good method (or place) to apply
a translation table from compatible values to modaliases. Ideally,
the translations should be part of the drivers themselves, but that
causes a chicken and egg problem of needing to load the driver to get
access to the table
This patch depends on the Grant Likely's SPI patches, so this is
for RFC only.
Also, later we'll able to remove OF_GPIO dependency.
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
Documentation/powerpc/booting-without-of.txt | 24
drivers/mmc/host/Kconfig |7
Hi Anton,
On Fri, 23 May 2008 22:28:42 +0400 Anton Vorontsov [EMAIL PROTECTED] wrote:
+++ b/drivers/mmc/host/of_mmc_spi.c
+static int of_mmc_spi_probe(struct spi_device *spi)
+ /*
+ * mmc_spi_probe will use drvdata, so we can't use it. Use node's
+ * data instead.
+ */
Yup, I like this approach better. I had been thinking about putting
this all in the same file (drivers/mmc/host/mmc_spi.c) instead of
exporting the probe/remove symbols and by using clear comment blocks
to divide the sections, but I've got no issues with this approach.
This is good work. Some
