Re: [RFC PATCH v2 00/11] Add (de)compression support to pstore

2013-08-19 Thread Tony Luck
On Sat, Aug 17, 2013 at 11:32 AM, Kees Cook keesc...@chromium.org wrote: Yeah, this is great. While I haven't tested it myself yet, the code seems to be in good shape. I acked the ram piece separately, but consider the entire series: Reviewed-by: Kees Cook keesc...@chromium.org Applied.

Re: [RFC PATCH v2 00/11] Add (de)compression support to pstore

2013-08-17 Thread Kees Cook
On Fri, Aug 16, 2013 at 3:15 PM, Luck, Tony tony.l...@intel.com wrote: Needs testing with erst backend, efivars and persistent ram. Tested against ERST - works fine for me now. Need to stare at the code to see if there are any more bits that could be cleaned up. Thanks for addressing my

[RFC PATCH v2 00/11] Add (de)compression support to pstore

2013-08-16 Thread Aruna Balakrishnaiah
Changes from v1: - Allocate compression workspace during initialisation as per Tony's suggestion - Copy the recent messages from big_oops_buf to psinfo-buf when compression fails, since the printk buffer would be fetched for compression calling it again

RE: [RFC PATCH v2 00/11] Add (de)compression support to pstore

2013-08-16 Thread Luck, Tony
Needs testing with erst backend, efivars and persistent ram. Tested against ERST - works fine for me now. Need to stare at the code to see if there are any more bits that could be cleaned up. Thanks for addressing my issues from v1 -Tony ___