On 2020-05-23 12:35, Souptick Joarder wrote:
...
Everything you have done here is an improvement, and I'd be happy to
see it go in (after fixing the bug I note below).
But in reading through it, I noticed almost every user ...
- if (__get_user_pages_fast(hva, 1, 1, &page) == 1) {
+ if
On Sat, May 23, 2020 at 10:55 PM Matthew Wilcox wrote:
>
> On Sat, May 23, 2020 at 10:11:12PM +0530, Souptick Joarder wrote:
> > Renaming the API __get_user_pages_fast() to get_user_pages_
> > fast_only() to align with pin_user_pages_fast_only().
>
> Please don't split a function name across lines
On Sat, May 23, 2020 at 10:11:12PM +0530, Souptick Joarder wrote:
> Renaming the API __get_user_pages_fast() to get_user_pages_
> fast_only() to align with pin_user_pages_fast_only().
Please don't split a function name across lines. That messes
up people who are grepping for the function name in
Renaming the API __get_user_pages_fast() to get_user_pages_
fast_only() to align with pin_user_pages_fast_only().
As part of this we will get rid of write parameter.
Instead caller will pass FOLL_WRITE to get_user_pages_fast_only().
This will not change any existing functionality of the API.
All