RE: [v11 6/7] arm64: dts: ls1046a: add qdma device tree nodes

2018-12-06 Thread Peng Ma 
Hi Shawn,

Thanks for your review , I have used GIC_SPI and IRQ_TYPE_xxx to my 
dtsi, please check and review.

Best Regard,
Peng

>-Original Message-
>From: Shawn Guo 
>Sent: 2018年12月6日 9:06
>To: Peng Ma 
>Cc: vk...@kernel.org; robh...@kernel.org; mark.rutl...@arm.com; Leo Li
>; dan.j.willi...@intel.com; z...@zh-kernel.org;
>dmaeng...@vger.kernel.org; devicet...@vger.kernel.org;
>linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
>linuxppc-dev@lists.ozlabs.org; Wen He 
>Subject: Re: [v11 6/7] arm64: dts: ls1046a: add qdma device tree nodes
>
>On Tue, Oct 30, 2018 at 10:36:03AM +0800, Peng Ma wrote:
>> add the qDMA device tree nodes for LS1046A devices.
>>
>> Signed-off-by: Wen He 
>> Signed-off-by: Peng Ma 
>> ---
>> change in v11:
>>  - no
>>
>>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi |   21
>+
>>  1 files changed, 21 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
>b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
>> index ef83786..dc65318 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
>> @@ -704,6 +704,27 @@
>>  < 0 0 4  GIC_SPI 154
>IRQ_TYPE_LEVEL_HIGH>;
>>  };
>>
>> +qdma: dma-controller@838 {
>> +compatible = "fsl,ls1046a-qdma", "fsl,ls1021a-qdma";
>> +reg = <0x0 0x838 0x0 0x1000>, /* Controller regs */
>> +  <0x0 0x839 0x0 0x1>, /* Status regs */
>> +  <0x0 0x83a 0x0 0x4>; /* Block regs */
>> +interrupts = <0 153 0x4>,
>> + <0 39 0x4>,
>> + <0 40 0x4>,
>> + <0 41 0x4>,
>> + <0 42 0x4>;
>
>Use GIC_SPI and IRQ_TYPE_xxx defines.
>
>Shawn
>
>> +interrupt-names = "qdma-error", "qdma-queue0",
>> +"qdma-queue1", "qdma-queue2", "qdma-queue3";
>> +dma-channels = <8>;
>> +block-number = <1>;
>> +block-offset = <0x1>;
>> +fsl,dma-queues = <2>;
>> +status-sizes = <64>;
>> +queue-sizes = <64 64>;
>> +big-endian;
>> +};
>> +
>>  };
>>
>>  reserved-memory {
>> --
>> 1.7.1
>>

Re: [v11 6/7] arm64: dts: ls1046a: add qdma device tree nodes

2018-12-05 Thread Shawn Guo 
On Tue, Oct 30, 2018 at 10:36:03AM +0800, Peng Ma wrote:
> add the qDMA device tree nodes for LS1046A devices.
> 
> Signed-off-by: Wen He 
> Signed-off-by: Peng Ma 
> ---
> change in v11:
>   - no
> 
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi |   21 +
>  1 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index ef83786..dc65318 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -704,6 +704,27 @@
>   < 0 0 4  GIC_SPI 154 
> IRQ_TYPE_LEVEL_HIGH>;
>   };
>  
> + qdma: dma-controller@838 {
> + compatible = "fsl,ls1046a-qdma", "fsl,ls1021a-qdma";
> + reg = <0x0 0x838 0x0 0x1000>, /* Controller regs */
> +   <0x0 0x839 0x0 0x1>, /* Status regs */
> +   <0x0 0x83a 0x0 0x4>; /* Block regs */
> + interrupts = <0 153 0x4>,
> +  <0 39 0x4>,
> +  <0 40 0x4>,
> +  <0 41 0x4>,
> +  <0 42 0x4>;

Use GIC_SPI and IRQ_TYPE_xxx defines.

Shawn

> + interrupt-names = "qdma-error", "qdma-queue0",
> + "qdma-queue1", "qdma-queue2", "qdma-queue3";
> + dma-channels = <8>;
> + block-number = <1>;
> + block-offset = <0x1>;
> + fsl,dma-queues = <2>;
> + status-sizes = <64>;
> + queue-sizes = <64 64>;
> + big-endian;
> + };
> +
>   };
>  
>   reserved-memory {
> -- 
> 1.7.1
>

[v11 6/7] arm64: dts: ls1046a: add qdma device tree nodes

2018-10-29 Thread Peng Ma 
add the qDMA device tree nodes for LS1046A devices.

Signed-off-by: Wen He 
Signed-off-by: Peng Ma 
---
change in v11:
- no

 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi |   21 +
 1 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi 
b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index ef83786..dc65318 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -704,6 +704,27 @@
< 0 0 4  GIC_SPI 154 
IRQ_TYPE_LEVEL_HIGH>;
};
 
+   qdma: dma-controller@838 {
+   compatible = "fsl,ls1046a-qdma", "fsl,ls1021a-qdma";
+   reg = <0x0 0x838 0x0 0x1000>, /* Controller regs */
+ <0x0 0x839 0x0 0x1>, /* Status regs */
+ <0x0 0x83a 0x0 0x4>; /* Block regs */
+   interrupts = <0 153 0x4>,
+<0 39 0x4>,
+<0 40 0x4>,
+<0 41 0x4>,
+<0 42 0x4>;
+   interrupt-names = "qdma-error", "qdma-queue0",
+   "qdma-queue1", "qdma-queue2", "qdma-queue3";
+   dma-channels = <8>;
+   block-number = <1>;
+   block-offset = <0x1>;
+   fsl,dma-queues = <2>;
+   status-sizes = <64>;
+   queue-sizes = <64 64>;
+   big-endian;
+   };
+
};
 
reserved-memory {
-- 
1.7.1